From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3500 invoked by alias); 4 Jun 2014 08:01:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3479 invoked by uid 89); 4 Jun 2014 08:01:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 08:01:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5481Zk5013243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 04:01:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5481W3o027004; Wed, 4 Jun 2014 04:01:33 -0400 Message-ID: <538ED25C.7000209@redhat.com> Date: Wed, 04 Jun 2014 08:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Yao Qi , Andreas Schwab CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA/7.8] user breakpoint not inserted if software-single-step at same location References: <1401394280-14999-1-git-send-email-brobecker@adacore.com> <5387BFF0.6010208@redhat.com> <20140530122253.GC4289@adacore.com> <53887ED5.5050603@redhat.com> <20140530132659.GD4289@adacore.com> <5388AA76.4070101@redhat.com> <538DB721.30308@codesourcery.com> <538DB8EC.20109@redhat.com> <538DBD65.5050409@redhat.com> <538EAACD.8000700@codesourcery.com> In-Reply-To: <538EAACD.8000700@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00136.txt.bz2 On 06/04/2014 06:12 AM, Yao Qi wrote: > On 06/03/2014 08:19 PM, Pedro Alves wrote: >> On 06/03/2014 01:12 PM, Andreas Schwab wrote: >>> Pedro Alves writes: >>> >>>> Ah, thanks. We need to replace then with asm("nop") then. >>> >>> nop isn't portable. >> >> Yes, but it doesn't matter what the instruction is as >> long as it's a single instruction that doesn't do much. >> For archs that don't have "nop" (like e.g., IA64), we can >> just use #ifdef to pick another insn. >> > > Pedro, here is the patch to tweak sss-bp-on-user-bp.exp. > I give up on looking for a portable "nop" for various arch. In > stead, we can use disassemble to get the next instruction address > and set breakpoint there. See details in the commit log below. Good idea. Patch is OK. Thanks! -- Pedro Alves