Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: [PATCH OBV] Fix a regexp pattern in gdb.base/auto-connect-native-target.exp (Re: [PATCH 8/8] Allow making GDB not automatically connect to the native target.)
Date: Tue, 03 Jun 2014 05:35:00 -0000	[thread overview]
Message-ID: <538D5E05.2000807@codesourcery.com> (raw)
In-Reply-To: <1395069784-7406-9-git-send-email-palves@redhat.com>

On 03/17/2014 11:23 PM, Pedro Alves wrote:
> +set test "help target native"
> +gdb_test_multiple $test $test {
> +    -re "Undefined target command.* $gdb_prompt $" {

The space before "$gdb_prompt $" looks redundant and this patch
is to remove it from the regexp pattern.

> +	set have_native 0
> +    }
> +    -re "Native process.*$gdb_prompt $" {
> +	set have_native 1
> +    }
> +}


-- 
Yao (齐尧)

Subject: [PATCH] Fix a regexp pattern in gdb.base/auto-connect-native-target.exp

When I test gdb head (for 7.8 release) on arm-none-eabi, I find the
following failure, which is caused by the improper regexp
pattern in the test.

(gdb) help target native^M
Undefined target command: "native".  Try "help target".^M
(gdb) FAIL: gdb.base/auto-connect-native-target.exp: help target native

The space before "$gdb_prompt $" looks redundant, and this patch
is to remove it from the regexp pattern.

gdb/testsuite:

2014-06-03  Yao Qi  <yao@codesourcery.com>

	* gdb.base/auto-connect-native-target.exp: Remove redundant
	space from the regexp pattern.
---
 gdb/testsuite/gdb.base/auto-connect-native-target.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/auto-connect-native-target.exp b/gdb/testsuite/gdb.base/auto-connect-native-target.exp
index ac8c79f..79febe3 100644
--- a/gdb/testsuite/gdb.base/auto-connect-native-target.exp
+++ b/gdb/testsuite/gdb.base/auto-connect-native-target.exp
@@ -27,7 +27,7 @@ set have_native 0
 
 set test "help target native"
 gdb_test_multiple $test $test {
-    -re "Undefined target command.* $gdb_prompt $" {
+    -re "Undefined target command.*$gdb_prompt $" {
 	set have_native 0
     }
     -re "Native process.*$gdb_prompt $" {
-- 
1.9.0


  parent reply	other threads:[~2014-06-03  5:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 15:23 [PATCH 0/8] Allow making GDB not automatically connect to the native target (and add "target native") Pedro Alves
2014-03-17 15:23 ` [PATCH 7/8] NEWS: Mention native target renames Pedro Alves
2014-03-17 16:45   ` Eli Zaretskii
2014-03-17 15:23 ` [PATCH 4/8] Windows: Rename "target child" -> "target native" Pedro Alves
2014-03-17 15:23 ` [PATCH 1/8] Rename "target djgpp" " Pedro Alves
2014-03-17 16:44   ` Eli Zaretskii
2014-03-17 15:23 ` [PATCH 6/8] go32-nat.c: Don't override to_open Pedro Alves
2014-03-17 16:44   ` Eli Zaretskii
2014-03-17 15:23 ` [PATCH 3/8] Rename "target GNU" -> "target native" Pedro Alves
2014-03-17 15:23 ` [PATCH 8/8] Allow making GDB not automatically connect to the native target Pedro Alves
2014-03-17 16:47   ` Eli Zaretskii
2014-03-18 21:55   ` Stan Shebs
2014-03-25 20:06   ` Doug Evans
2014-05-21 17:53     ` Pedro Alves
2014-06-03  5:35   ` Yao Qi [this message]
2014-03-17 15:23 ` [PATCH 5/8] nto-procfs.c: Add "target native" Pedro Alves
2014-03-17 15:23 ` [PATCH 2/8] Rename "target darwin-child" -> " Pedro Alves
2014-03-17 17:01 ` [PATCH 0.5/8] Rename "target child" to " Pedro Alves
2014-03-17 17:02 ` Pedro Alves
2014-06-03  5:29   ` [PATCH OBV] Fix regexp pattern in gdb.base/default.exp (Re: [PATCH 0.5/8] Rename "target child" to "target native".) Yao Qi
2014-05-21 17:57 ` [pushed] Re: [PATCH 0/8] Allow making GDB not automatically connect to the native target (and add "target native") Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538D5E05.2000807@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox