From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14296 invoked by alias); 29 May 2014 17:03:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14279 invoked by uid 89); 29 May 2014 17:03:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 May 2014 17:03:53 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4TH3owN015660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 May 2014 13:03:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4TH3nId004377; Thu, 29 May 2014 13:03:49 -0400 Message-ID: <53876874.3080503@redhat.com> Date: Thu, 29 May 2014 17:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3 3/3] btrace, vdso: add vdso target sections References: <1400655682-4014-1-git-send-email-markus.t.metzger@intel.com> <1400655682-4014-3-git-send-email-markus.t.metzger@intel.com> <5387663A.5040704@redhat.com> In-Reply-To: <5387663A.5040704@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00731.txt.bz2 On 05/29/2014 05:54 PM, Pedro Alves wrote: > Hi Markus, > > On 05/21/2014 08:01 AM, Markus Metzger wrote: >> When loading symbols for the vdso, also add its sections to target_sections. >> >> This fixes an issue with record btrace where vdso instructions could not be >> disassembled during replay. >> >> 2014-05-21 Markus Metzger >> >> * symfile-mem.c (symbol_file_add_from_memory): Add BFD sections. > > Unfortunately this caused regressions in break-interp.exp: > > Running ../../../src/gdb/testsuite/gdb.base/break-interp.exp ... > ERROR: Process no longer exists > > That is GDB crashing. > > 589fdceb99db9868e34bc976b7e234dbfaf327e2 is the first bad commit > commit 589fdceb99db9868e34bc976b7e234dbfaf327e2 > Author: Markus Metzger > Date: Wed Apr 2 09:54:11 2014 +0200 > > btrace, vdso: add vdso target sections > > When loading symbols for the vdso, also add its sections to target_sections. > > This fixes an issue with record btrace where vdso instructions could not be > disassembled during replay. > > * symfile-mem.c (symbol_file_add_from_memory): Add BFD sections. > > testsuite/ > * gdb.btrace/vdso.c: New. > * gdb.btrace/vdso.exp: New. > > > Core was generated by `/home/pedro/gdb/mygit/build/gdb/testsuite/../../gdb/gdb -nw -nx -data-directory'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x0000000000647bce in exec_set_section_address (filename=0x27bb1f0 "/home/pedro/gdb/mygit/build/gdb/testsuite/gdb.base/break-interp-LDprelinkNOdebugNO", index=0, > address=139930618982856) at ../../src/gdb/exec.c:919 > 919 if (filename_cmp (filename, p->the_bfd_section->owner->filename) == 0 'p', a target section, points at garbage. Hmm, wait, nothing is removing the vdso symbols target sections, like ever, not even when the process dies, isn't it? I guess that's it. -- Pedro Alves