From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23238 invoked by alias); 27 May 2014 18:15:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23226 invoked by uid 89); 27 May 2014 18:15:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 18:15:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4RIFXmp023673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 May 2014 14:15:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4RIFWLm005610; Tue, 27 May 2014 14:15:32 -0400 Message-ID: <5384D643.1070707@redhat.com> Date: Tue, 27 May 2014 18:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Hui Zhu CC: Hui Zhu , gdb-patches ml Subject: Re: [PATCH] Fix ptype.exp fail in MIPS References: <53719B17.5000208@mentor.com> <5374FF0D.6060608@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00676.txt.bz2 On 05/16/2014 08:40 AM, Hui Zhu wrote: > On Fri, May 16, 2014 at 1:53 AM, Pedro Alves wrote: >> On 05/13/2014 05:09 AM, Hui Zhu wrote: >>> ptype $pc >>> type = int32_t >>> (gdb) FAIL: gdb.base/ptype.exp: ptype $pc >>> This is because the $pc register in MIPS is set to int but not code_ptr. >>> And according to the discussion in >>> https://sourceware.org/ml/gdb/2013-06/msg00020.html, the type cannot be >>> changed. >> >> Hmm, that's not what I get from this branch of the discussion: >> >> https://sourceware.org/ml/gdb/2013-06/msg00021.html >> >> -- > > https://sourceware.org/ml/gdb/2013-06/msg00032.html That was an alternative proposal, but nobody replied saying it was a great idea, so I don't know. The main disadvantage is that the user would have to know about these different registers, which may be confusing and obscure. > Do you think add ptr64 or $_xx is OK for you to handle this issue? I'm leaning torwards ptr64. Anyone see a reason why that wouldn't work? That was also sort of agreed upon by both Mark and Maciej at: https://sourceware.org/ml/gdb/2013-06/msg00029.html " > Overall I think the test is too strict. If you think the use of "long > long" is unfortunate for the PC, then an artificial type might be created > internally within GDB specifically for the PC, similarly to what we do > e.g. for IEEE 754 data types and floating-point registers in some cases. An artificial type like that probably is the way to go. " But of course that was a while ago and they might have changed their minds since. -- Pedro Alves