From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28415 invoked by alias); 27 May 2014 01:37:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28398 invoked by uid 89); 27 May 2014 01:37:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 01:37:57 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wp6Kt-0004iv-N7 from Yao_Qi@mentor.com ; Mon, 26 May 2014 18:37:51 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 26 May 2014 18:37:51 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Mon, 26 May 2014 18:37:50 -0700 Message-ID: <5383EBE5.4060709@codesourcery.com> Date: Tue, 27 May 2014 01:37:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Andreas Arnez , CC: Andreas Schwab Subject: Re: [PATCH 11/12] M68K Linux: Define regset structures. References: <1401122208-2481-1-git-send-email-arnez@linux.vnet.ibm.com> <1401122208-2481-12-git-send-email-arnez@linux.vnet.ibm.com> In-Reply-To: <1401122208-2481-12-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00642.txt.bz2 On 05/27/2014 12:36 AM, Andreas Arnez wrote: > +/* Return the appropriate register set for the core section identified > + by SECT_NAME and SECT_SIZE. */ > + > +static const struct regset * > +m68k_linux_regset_from_core_section (struct gdbarch *gdbarch, > + const char *sect_name, > + size_t sect_size) > +{ > + if (strcmp (sect_name, ".reg") == 0 > + && sect_size >= M68K_LINUX_GREGS_SIZE) > + return &m68k_linux_gregset; > + > + if (strcmp (sect_name, ".reg2") == 0 > + && sect_size >= M68K_LINUX_FPREGS_SIZE) > + return &m68k_linux_fpregset; > + > + return NULL; > +} > + > static void > m68k_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > { > @@ -361,6 +422,10 @@ m68k_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > > set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target); > > + /* Core file support. */ > + set_gdbarch_regset_from_core_section > + (gdbarch, m68k_linux_regset_from_core_section); > + Is it intended to include this change in this patch? or it should go to the next patch series? -- Yao (齐尧)