From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15356 invoked by alias); 23 May 2014 18:57:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15347 invoked by uid 89); 23 May 2014 18:57:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 23 May 2014 18:57:16 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 9D.BE.11744.3C74F735; Fri, 23 May 2014 15:06:11 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 23 May 2014 14:57:11 -0400 Message-ID: <537F9A07.9090107@ericsson.com> Date: Fri, 23 May 2014 18:57:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pedro Alves CC: , Tom Tromey Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups References: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com> <87mweh31qi.fsf@fleche.redhat.com> <537CE38B.7040000@ericsson.com> <537CEBCB.5020401@redhat.com> In-Reply-To: <537CEBCB.5020401@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00591.txt.bz2 On Wed 21 May 2014 02:09:15 PM EDT, Pedro Alves wrote: > On 05/21/2014 06:34 PM, Simon Marchi wrote: >> On Fri 16 May 2014 04:30:45 PM EDT, Tom Tromey wrote: >>>>>>>> "Simon" == Simon Marchi writes: >>> >>> Simon> This one was also from a year ago, I would like to make sure it is still >>> Simon> OK. >>> >>> Simon> + if (inferior->has_exit_code) >>> Simon> + ui_out_field_string (uiout, "exit-code", >>> Simon> + int_string (inferior->exit_code, 8, 0, 0, 1)); >>> >>> Why not the simpler ui_out_field_int? >>> Going out of the way to print it in octal seems a bit odd for a machine >>> interface. >>> >>> Tom >> >> Agreed. I found that the exit code is often represented in octal (the >> reason for this probably predates my birth). But for MI, it does not >> matter. > > Though it might be a little less surprising if all places that print > the exit code print it the same way. That way it's possible that > frontends just treat the exit code as a string, and present it as > is to the user. They may already be doing that. > > The =thread-group-exited code has: > > mi_inferior_exit (struct inferior *inf) > { > struct mi_interp *mi = top_level_interpreter_data (); > > target_terminal_ours (); > if (inf->has_exit_code) > fprintf_unfiltered (mi->event_channel, > "thread-group-exited,id=\"i%d\",exit-code=\"%s\"", > inf->num, int_string (inf->exit_code, 8, 0, 0, 1)); > > (I bet that's where the new code was copied from.) Yes probably. It is hard to remember, it has been so long.