From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28823 invoked by alias); 23 May 2014 08:04:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28804 invoked by uid 89); 23 May 2014 08:04:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 May 2014 08:04:03 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 335FE13F64F; Fri, 23 May 2014 03:03:56 -0500 (CDT) Message-ID: <537F00EB.5090601@arm.com> Date: Fri, 23 May 2014 08:04:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c References: <537DBDF3.1080907@arm.com> <20140522124927.GR22822@adacore.com> In-Reply-To: <20140522124927.GR22822@adacore.com> Content-Type: multipart/mixed; boundary="------------070307070406010807010508" X-SW-Source: 2014-05/txt/msg00582.txt.bz2 This is a multi-part message in MIME format. --------------070307070406010807010508 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-length: 720 On 05/22/14 13:49, Joel Brobecker wrote: >> A recent change to glibc removed asm/ptrace.h from user.h for >> AArch64. This meant that cross-native builds of gdb using trunk >> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >> couldn't be found. >> >> Fixed by including asm/ptrace.h like other ports. > > Thanks for the explanation. Can you make sure you include that > in the revision history of your commit? > >> 2014-05-22 Ramana Radhakrishnan >> >> * aarch64-linux-nat.c (asm/ptrace.h): Include. >> > > OK to push. Thank you. > > Thanks - I've got a similar one in gdbserver which I somehow managed to miss yesterday. Ok to push ? regards Ramana --------------070307070406010807010508 Content-Type: text/plain; charset=us-ascii; name="p1.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="p1.txt" Content-length: 1388 commit e9dae05e9c32efda9724330c6d5ade3ca848591d Author: Ramana Radhakrishnan Date: Fri May 23 09:01:14 2014 +0100 Include asm/ptrace.h for linux-aarch64-low.c A recent change to glibc removed asm/ptrace.h from user.h for AArch64. This meant that cross-native builds of gdbserver using trunk glibc broke because linux-aarch64-low.c because user_hwdebug_state couldn't be found. This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e 2014-05-23 Ramana Radhakrishnan * linux-aarch64-low.c (asm/ptrace.h): Include. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 81bd30e..e591108 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2014-05-23 Ramana Radhakrishnan + + * linux-aarch64-low.c (asm/ptrace.h): Include. + 2014-05-21 Jan Kratochvil Fix TLS access for -static -pthread. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 033e79e..6066e15 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include "gdb_proc_service.h" --------------070307070406010807010508--