From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15121 invoked by alias); 21 May 2014 19:45:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15100 invoked by uid 89); 21 May 2014 19:45:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 19:45:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LJjYHO003637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 21 May 2014 15:45:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LJjXIX014246; Wed, 21 May 2014 15:45:34 -0400 Message-ID: <537D025D.3090207@redhat.com> Date: Wed, 21 May 2014 19:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] constify to_attach References: <1400696455-29563-1-git-send-email-tromey@redhat.com> In-Reply-To: <1400696455-29563-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00513.txt.bz2 On 05/21/2014 07:20 PM, Tom Tromey wrote: > The code in parse_pid_to_attach seems a little bogus to me. If there > is a platform with a broken strtoul, we have better methods for fixing > the issue now. However, I left the code as is since it is clearly ok > to do so. Yeah. We should probably use get_number or some such that accepts convenience vars even. > +parse_pid_to_attach (const char *args) > { > unsigned long pid; > char *dummy; > @@ -3257,7 +3257,7 @@ parse_pid_to_attach (char *args) > if (!args) > error_no_arg (_("process-id to attach")); > > - dummy = args; > + dummy = (char *) args; > pid = strtoul (args, &dummy, 0); > /* Some targets don't set errno on errors, grrr! */ > if ((pid == 0 && dummy == args) || dummy != &args[strlen (args)]) errno would be necessary to catch overflow, but not to check whether the number was syntactically correct. strtoul always sets *endptr to point to the address of the first invalid character (and never to NULL). So you could just remove the 'dummy' assignment. But I'll understand if you want to keep it. The patch looks fine to me. -- Pedro Alves