From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28920 invoked by alias); 21 May 2014 17:34:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28838 invoked by uid 89); 21 May 2014 17:34:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 May 2014 17:34:07 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 96.62.11744.0619C735; Wed, 21 May 2014 13:43:29 +0200 (CEST) Received: from [142.133.183.104] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 21 May 2014 13:34:03 -0400 Message-ID: <537CE38B.7040000@ericsson.com> Date: Wed, 21 May 2014 17:34:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups References: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com> <87mweh31qi.fsf@fleche.redhat.com> In-Reply-To: <87mweh31qi.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00492.txt.bz2 On Fri 16 May 2014 04:30:45 PM EDT, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> This one was also from a year ago, I would like to make sure it is still > Simon> OK. > > Simon> + if (inferior->has_exit_code) > Simon> + ui_out_field_string (uiout, "exit-code", > Simon> + int_string (inferior->exit_code, 8, 0, 0, 1)); > > Why not the simpler ui_out_field_int? > Going out of the way to print it in octal seems a bit odd for a machine > interface. > > Tom Agreed. I found that the exit code is often represented in octal (the reason for this probably predates my birth). But for MI, it does not matter. Simon