From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16250 invoked by alias); 21 May 2014 02:31:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16232 invoked by uid 89); 21 May 2014 02:31:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 02:31:02 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WmwJ0-00027z-Ej from Yao_Qi@mentor.com ; Tue, 20 May 2014 19:30:58 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 20 May 2014 19:30:55 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Tue, 20 May 2014 19:30:53 -0700 Message-ID: <537C0F4A.8060708@codesourcery.com> Date: Wed, 21 May 2014 02:31:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 3/3] [GDBserver] Make Zx/zx packet handling idempotent. References: <1398296475-27997-1-git-send-email-palves@redhat.com> <1398296475-27997-4-git-send-email-palves@redhat.com> In-Reply-To: <1398296475-27997-4-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00452.txt.bz2 The patch is good! On 04/24/2014 07:41 AM, Pedro Alves wrote: > So the fix is to generalize mem-break.c to track all kinds of Zx > breakpoints, and filter out duplicates. As mentioned, this ends up > adding support for target-side conditions on hardware breakpoints and > watchpoints too (though GDB itself doesn't support the latter yet). > Can GDBserver returns feature "ConditionalWatchpoints" for qSupported query now? > As software/memory breakpoints work by poking at memory, when setting > a GDB Z0 breakpoint (but not internal breakpoints, as those can assume > the conditions are already right), we need to tell the target to > prepare to access memory (which on Linux means stop threads). If that > operation fails, we need to return error to GDB. Seeing an error, if > this is the first breakpoint of that type that GDB tries to insert, > GDB would then assume the breakpoint type is supported, but it may > actually not be. So we need to check whether the type is supported at I am confused by this, isn't it "GDB would then assume the breakpoint type is NOT supported, but it may actually be"? -- Yao (齐尧)