From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13558 invoked by alias); 19 May 2014 14:07:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13427 invoked by uid 89); 19 May 2014 14:07:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 14:07:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4JE72WD020259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2014 10:07:03 -0400 Received: from localhost.localdomain (ovpn-112-22.ams2.redhat.com [10.36.112.22]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4JE71iG031511; Mon, 19 May 2014 10:07:01 -0400 Message-ID: <537A1004.9040404@redhat.com> Date: Mon, 19 May 2014 14:07:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Doug Evans , Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 05/14] change how the CLI handles comments References: <1400253995-12333-1-git-send-email-tromey@redhat.com> <1400253995-12333-6-git-send-email-tromey@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00344.txt.bz2 On 19/05/14 00:26, Doug Evans wrote: > On Fri, May 16, 2014 at 8:26 AM, Tom Tromey wrote: >> diff --git a/gdb/top.c b/gdb/top.c >> index fa20025..16694e6 100644 >> --- a/gdb/top.c >> +++ b/gdb/top.c >> @@ -560,11 +560,14 @@ command_loop (void) >> >> make_command_stats_cleanup (1); >> >> - execute_command (command, instream == stdin); >> - >> - /* Do any commands attached to breakpoint we are stopped at. */ >> - bpstat_do_actions (); >> + /* Do not execute commented lines. */ >> + if (command[0] != '#') >> + { >> + execute_command (command, instream == stdin); >> >> + /* Do any commands attached to breakpoint we are stopped at. */ >> + bpstat_do_actions (); >> + } >> do_cleanups (old_chain); >> } >> } >> @@ -1057,15 +1060,6 @@ command_line_input (char *prompt_arg, int repeat, char *annotation_suffix) >> if (*linebuffer && input_from_terminal_p ()) >> add_history (linebuffer); >> >> - /* Note: lines consisting solely of comments are added to the command >> - history. This is useful when you type a command, and then >> - realize you don't want to execute it quite yet. You can comment >> - out the command and then later fetch it from the value history >> - and remove the '#'. The kill ring is probably better, but some >> - people are in the habit of commenting things out. */ >> - if (*p1 == '#') >> - *p1 = '\0'; /* Found a comment. */ >> - >> /* Save into global buffer if appropriate. */ >> if (repeat) >> { >> -- >> 1.9.0 >> > > Hi. I have an equivalent patch that I need for guile support. > E.g., > guile > (foo > #:bar 42) > end > > Since this is really independent of the rest of the patch set, > can this be checked in right away? > TIA I have no problems with you checking this patch in as long as nobody else objects. Lets give it a day or so for people to speak up. Pending that I would say go ahead. Cheers, Phil