From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4957 invoked by alias); 16 May 2014 15:37:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4943 invoked by uid 89); 16 May 2014 15:37:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 May 2014 15:37:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GFb300004678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2014 11:37:03 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4GFb2QQ022523; Fri, 16 May 2014 11:37:02 -0400 Message-ID: <5376309D.4070902@redhat.com> Date: Fri, 16 May 2014 15:37:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/4] Remove previous frame if an error occurs when computing frame id during unwind. References: <533EC5B7.6080600@broadcom.com> <1398855344-25278-1-git-send-email-aburgess@broadcom.com> <1398855344-25278-3-git-send-email-aburgess@broadcom.com> In-Reply-To: <1398855344-25278-3-git-send-email-aburgess@broadcom.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00295.txt.bz2 On 04/30/2014 11:55 AM, Andrew Burgess wrote: > In get_prev_frame_if_no_cycle, if we throw an error during compute_frame_id > then we are left in a state where THIS_FRAME has a PREV_FRAME attached, but > PREV_FRAME has no frame id. This is an unexpected state that causes > internal errors and assertions to fire. > > This patch adds a cleanup that removes the previous frame created by > get_prev_frame_raw if we get an error. > > OK to apply? This is OK. Thank you. (I guess it could go in immediately if you adjust the test to expect the error and only try each command once.) I was looking at the rest of the series, but something came up and I'm afraid I won't be able to reply today. Sigh. :-( -- Pedro Alves