From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic310-11.consmr.mail.ir2.yahoo.com (sonic310-11.consmr.mail.ir2.yahoo.com [77.238.177.32]) by sourceware.org (Postfix) with ESMTPS id D26CC385DC29 for ; Wed, 1 Apr 2020 17:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D26CC385DC29 X-YMail-OSG: C.D.3XsVM1my9ffkIr7I5lFQL5eOC0XK8mIcmsJimpygmq4leoYP7ZzDtyDd7vo 6AS37wkUvnxMdaAcaFlbTjpIEtzY19eR538dcNgekEqq6BxqBPFjzI.w5NKQF3VpdXPcwIrVze8. 9XJGINelEqMglDXevDAaRNL8o8GrOMKrvEARwnkj6osYCQ28BD4lAERyW6kYE3nK9yfI1e1WxjOC lcI1XrCHIila66gslF4c3UPFcBiyMwFxevXsxEe9RipO0YviXTr8n.XUzfmtVFIqUTvUXHh1v3C2 kyeLAKGTsxbhfA08vMm98t4VTM3r8_eFomY_PkGP9wXNIrUm2DJ9HXixhb9X24SsvKTlWFRb9sWt kCM8wLi03j62ET_YOkg9WtAxBgT4kdXqErBQujaePuTR75ZsdDj689sHUATJK.OY94.Ogt4s0DV1 GNK2vCo9SKpbo4Liu9vnb7o.iaBaf8bBgmxgGS6WQlsK99fYzjbmmAK1jhkXAPV4TG3vWsy1OhO1 BiCXukxYZL4Q3v5Wf1pzs.x1P7aAiPiT2ue.27.V4dtfOEYIcL9WpxTiNubdcoYRjcvTRiw32nhB 1OkqOz1WdfV0V.uExItFsuT9HKmeIFjw725LaFy9d9gQGUObRDHsTxYUXV5VwvV1N4wD.Lgi8Lei TpBNfeA_wX4Hp9vvpcNpWS391qQIt58Xxi7Gv4eiM0GSwWg9ZINum3Ngie4K1Gv48U5UGmQ7offM y2nAvtBxPsXF0V8oDC2cnS8Y60TYmMOPAOtM1vzUB3Sgfq4wigvRQbaC.ztGB3K3mMst6sNnVW64 L4ztDHqu_KeOZV5qvBaUh83sC3noYmTluS2aeRH_cPLP40auZGloze_oXCgtACdLQnY4Ws4t4rjv Or6sLqFCvXF.3XzrqQSparwxx4cjSMfMxQaCkadm9H15nmmZjs6FFeJFDvLHblf673baqM_mWOsG D6AhrKiS6yXQKdrWmEmRBATdIqBA8hd7zpjjwoxyI0q.l8_ymvlHhoq3D7g5hPo0Psre_HYgJ6ye cmE1EXYGacH9xd2HKvK5b9OOFw0GgmW2rHGIgJC9oSzgAjiYeOUtIxHSTPXQ_Oj7bbdMf69XUuVx _ilncHehlNh46yJeHIIFR1kayXXJ90QtMPRbg6rE8KuAhVtSwJHHmzR4WdLC31A4K_eEGfY1j2JO XpNoKGPYT1LK1ys8vwz3xxfbeKCVDIUTzmBtSU7ZCqqQjBjXXiVt27N5pgQ0hubWy5R8D7ppgwNU kuTai_ehrMVoO0lkVGGx7TnjA9MyecKh1LRGBR8G76RBLeTg5hd5U1UMzbpcQPhpDeGcNB71ubQq 1K5gRNJL0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Wed, 1 Apr 2020 17:17:50 +0000 Date: Wed, 1 Apr 2020 17:17:50 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <537466658.992778.1585761470024@mail.yahoo.com> In-Reply-To: <871rp740ys.fsf@tromey.com> References: <20200331220655.4436-1-ssbssa.ref@yahoo.de> <20200331220655.4436-1-ssbssa@yahoo.de> <871rp740ys.fsf@tromey.com> Subject: Re: [PATCH v2][PR gdb/24789] Allow pointer arithmetic with integer references MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15585 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 17:17:55 -0000 Am Mittwoch, 1. April 2020, 18:36:47 MESZ hat Tom Tromey = Folgendes geschrieben: > >>>>> "Hannes" =3D=3D Hannes Domani via Gdb-patches writes: > > Hannes> 2020-04-01=C2=A0 Hannes Domani=C2=A0 > > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 PR gdb/24789 > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 * eval.c (is_integral_or_integral_referen= ce): New function. > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 (evaluate_subexp_standard): Allow integer= references in > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 pointer arithmetic. > > Thank you. > > Hannes> +/* Return true if type is integral or reference to integral */ > Hannes> + > Hannes> +static bool > Hannes> +is_integral_or_integral_reference (struct type *type) > Hannes> +{ > Hannes> +=C2=A0 if (is_integral_type (type)) > Hannes> +=C2=A0=C2=A0=C2=A0 return true; > Hannes> + > Hannes> +=C2=A0 type =3D check_typedef (type); > Hannes> +=C2=A0 return type !=3D nullptr > Hannes> +=C2=A0=C2=A0=C2=A0 && TYPE_IS_REFERENCE (type) > Hannes> +=C2=A0=C2=A0=C2=A0 && is_integral_type (TYPE_TARGET_TYPE (type))= ; > > This needs parens around the multi-line expression, like: > > >=C2=A0=C2=A0 return (type !=3D nullptr >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && TYPE_IS_REFERENCE (type) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && is_integral_type (TYPE_TARGET_TYPE= (type))); > > > The patch is ok with this tweak. Pushed with this change, thanks. Hannes