From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8671 invoked by alias); 8 May 2014 05:44:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8655 invoked by uid 89); 8 May 2014 05:44:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 May 2014 05:44:02 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WiH7f-0000dx-7v from Yao_Qi@mentor.com ; Wed, 07 May 2014 22:43:59 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 May 2014 22:43:59 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Wed, 7 May 2014 22:43:58 -0700 Message-ID: <536B1916.5010100@codesourcery.com> Date: Thu, 08 May 2014 05:44:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Don Breazeal , CC: Don Breazeal Subject: Re: [PATCH 2/4][REPOST] Remote Linux ptrace exec events References: <1398885482-8449-1-git-send-email-donb@codesourcery.com> <1398885482-8449-3-git-send-email-donb@codesourcery.com> In-Reply-To: <1398885482-8449-3-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00077.txt.bz2 I don't have much based on Luis's comments. Two nits on changelog: On 05/01/2014 03:18 AM, Don Breazeal wrote: > gdbserver/ > 2014-04-02 Don Breazeal > > * gdb/gdbserver/linux-low.c (linux_child_pid_to_exec_file): New ^^^^^^^^^^^^^ There is a ChangeLog file in gdb/gdbserver directory, so don't need to have "gdb/gdbserver/" in file name. "* linux-low.c (...." should be fine. > function. > (handle_extended_wait): Add support for PTRACE_EVENT_EXEC. > (check_zombie_leaders): Update comment. > (linux_low_filter_event): Add support for PTRACE_EVENT_EXEC. > (linux_wait_for_event_filtered): Update comment. > (extended_event_reported): New function. > (send_sigstop): Delete lwp on 'No such process' error and > reset current_inferior. > * gdb/gdbserver/linux-low.h (struct lwp_info): New member > 'waitstatus'. We document new member with angle brackets, like * linux-low.h (struct lwp_info) : New member. -- Yao (齐尧)