Re: [PATCH 2/4][REPOST] Remote Linux ptrace exec events

Yao Qi
2014-05-08T05:44:04Z

I don't have much based on Luis's comments. Two nits on changelog:

On 05/01/2014 03:18 AM, Don Breazeal wrote:
> gdbserver/
> 2014-04-02 Don Breazeal <donb@codesourcery.com>
>
> * gdb/gdbserver/linux-low.c (linux_child_pid_to_exec_file): New
^^^^^^^^^^^^^

There is a ChangeLog file in gdb/gdbserver directory, so don't need to
have "gdb/gdbserver/" in file name. "* linux-low.c (...." should be fine.

> function.
> (handle_extended_wait): Add support for PTRACE_EVENT_EXEC.
> (check_zombie_leaders): Update comment.
> (linux_low_filter_event): Add support for PTRACE_EVENT_EXEC.
> (linux_wait_for_event_filtered): Update comment.
> (extended_event_reported): New function.
> (send_sigstop): Delete lwp on 'No such process' error and
> reset current_inferior.
> * gdb/gdbserver/linux-low.h (struct lwp_info): New member
> 'waitstatus'.

We document new member with angle brackets, like

* linux-low.h (struct lwp_info) <waitstatus>: New member.

--
Yao (é½å°§)