From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26630 invoked by alias); 7 May 2014 15:33:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26619 invoked by uid 89); 7 May 2014 15:33:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 May 2014 15:33:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Wi3qq-0004Ea-FZ from Taimoor_Mirza@mentor.com ; Wed, 07 May 2014 08:33:44 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 May 2014 08:33:43 -0700 Received: from [137.202.157.53] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Wed, 7 May 2014 16:33:42 +0100 Message-ID: <536A5254.3030402@codesourcery.com> Date: Wed, 07 May 2014 15:33:00 -0000 From: tmirza User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Will Newton , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction References: <1399448485-1740-1-git-send-email-tmirza@codesourcery.com> <20140507132511.GB4063@adacore.com> In-Reply-To: <20140507132511.GB4063@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00068.txt.bz2 On 05/07/2014 06:25 PM, Joel Brobecker wrote: >>> 2014-05-06 Taimoor Mirza >>> >>> gdb/ >>> * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for >>> ldr.w and ldrd instructions. > [...] >> This looks good to me, assuming the testsuite was run with no regressions. Thanks for the review Will. Yes I ran testsuites. > Thanks, Will, for reviewing the patch. I concur on both counts: > patch is approved, but can you please also confirm how the patch > was tested? I ran testsuites before and after applying my patch and did not find any regression. > > Thank you,