From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112183-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30619 invoked by alias); 2 May 2014 18:56:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30609 invoked by uid 89); 2 May 2014 18:56:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 May 2014 18:56:29 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s42IuRp4008090	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 2 May 2014 14:56:28 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s42IuQbr011990;	Fri, 2 May 2014 14:56:27 -0400
Message-ID: <5363EA5A.1000209@redhat.com>
Date: Fri, 02 May 2014 18:56:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Sergio Durigan Junior <sergiodj@redhat.com>
CC: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments
References: <1398981131-11720-1-git-send-email-sergiodj@redhat.com> <1398981131-11720-2-git-send-email-sergiodj@redhat.com> <53636901.9090601@redhat.com> <m3lhuk40pm.fsf@redhat.com> <m3oazg2gys.fsf@redhat.com>
In-Reply-To: <m3oazg2gys.fsf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-05/txt/msg00021.txt.bz2

On 05/02/2014 07:06 PM, Sergio Durigan Junior wrote:
> On Friday, May 02 2014, I wrote:
> 
>> Here's what I am going to push by the end of the day if there are no
>> other comments.
> 
> Pedro brought something else to my attention: the testcase messages were
> not unique, and I could rewrite it in order to make it more
> automatized.  So here is the third version that I will push if there are
> no other comments.

Thanks!  Looks great.

FYI, with {} instead of [list ...] one can avoid the backslashes.
That is, one can write:

 foreach probe_name {foo bar foo_prefix bar_prefix} \
     probe_val {42 42 42 42} \
     probe_reg_val {"$rsp" "$rbp - 8" "$rsp" "$rbp - 8"} {

instead of:

 foreach probe_name [list "foo" "bar" "foo_prefix" "bar_prefix"] \
     probe_val [list "42" "42" "42" "42"] \
     probe_reg_val [list "\$rsp" "\$rbp - 8" "\$rsp" "\$rbp - 8"] {
     with_test_prefix $probe_name {

Just a suggestion, it doesn't matter at all.

-- 
Pedro Alves