From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23423 invoked by alias); 2 May 2014 09:49:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23405 invoked by uid 89); 2 May 2014 09:49:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 May 2014 09:49:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s429nIrK006869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 2 May 2014 05:49:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s429nGMe019695; Fri, 2 May 2014 05:49:17 -0400 Message-ID: <53636A1C.8000806@redhat.com> Date: Fri, 02 May 2014 09:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: [PATCH 2/2] Extend recognized types of SDT probe's arguments References: <1398981131-11720-1-git-send-email-sergiodj@redhat.com> <1398981131-11720-3-git-send-email-sergiodj@redhat.com> In-Reply-To: <1398981131-11720-3-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00016.txt.bz2 On 05/01/2014 10:52 PM, Sergio Durigan Junior wrote: > This commit is actually an update to make the parser in > gdb/stap-probe.c be aware of all the possible prefixes that a probe > argument can have. According to the section "Argument Format" in: > > > > The bitness of the arguments can be 8, 16, 32 or 64 bits, signed or > unsigned. Currently GDB recognizes only 32 and 64-bit arguments. Looks good. > This commit extends this. Since this is a straightforward extension, > I am not submitting a testcase; I can do that if anybody wants. I think it'd be good to have a test -- the code that triggered the other bug was also supposedly straightforward. :-) Can we do this in C ? Ideally we'd also test that we don't crash with an invalid bitness (the complaint path). > > gdb/ > 2014-05-01 Sergio Durigan Junior > > stap-probe.c (enum stap_arg_bitness): New enums to represent 8 Missing '*'- > and 16-bit signed and unsigned arguments. > (stap_parse_probe_arguments): Extend code to handle such > arguments. -- Pedro Alves