From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20470 invoked by alias); 2 May 2014 09:44:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20455 invoked by uid 89); 2 May 2014 09:44:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 May 2014 09:44:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s429iZI1031683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 2 May 2014 05:44:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s429iXAq017983; Fri, 2 May 2014 05:44:34 -0400 Message-ID: <53636901.9090601@redhat.com> Date: Fri, 02 May 2014 09:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments References: <1398981131-11720-1-git-send-email-sergiodj@redhat.com> <1398981131-11720-2-git-send-email-sergiodj@redhat.com> In-Reply-To: <1398981131-11720-2-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00015.txt.bz2 On 05/01/2014 10:52 PM, Sergio Durigan Junior wrote: > gdb/testsuite/ > 2014-05-01 Sergio Durigan Junior > > PR breakpoints/16889 > * gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.S: New file. > * gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp: Likewise. No "gdb/testsuite/" in the entries. > --- l-prefix.S b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.S > new file mode 100644 > index 0000000..9c86f2d > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.S > @@ -0,0 +1,29 @@ > +/* Copyright (C) 2014 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > + .file "amd64-stap-optional-prefix.S" I think a line break after the include would read better. > + .text > + .globl main > +main: > + mov %rsp,%rbp > + pushq $42 > + STAP_PROBE1(probe, foo, (%rsp)) > + STAP_PROBE1(probe, bar, -8(%rbp)) What controls whether the optional prefix is included? Could we perhaps add two extra probes that probe the same values, but use the optional prefix? Something to the effect of: STAP_PROBE1(probe, foo, (%rsp)) STAP_PROBE1(probe, bar, -8(%rbp)) STAP_PROBE1(probe, foo_prefix, 8@(%rsp)) STAP_PROBE1(probe, bar_prefix, 8@-8(%rbp)) (but I'm clueless on how that is actually written.) > + mov %rbp,%rsp > + xor %rax,%rax > + ret > diff --git a/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp > new file mode 100644 > index 0000000..9747dc8 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/amd64-stap-optional-prefix.exp > @@ -0,0 +1,50 @@ > +# Copyright 2014 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This testcase is for PR breakpoints/16889 > + > +if { ![istarget "x86_64-*-*"] } { > + verbose "Skipping amd64-stap-special-operands.exp" > + return > +} > + > +standard_testfile ".S" If you swap these, you can use $testfile: standard_testfile ".S" if { ![istarget "x86_64-*-*"] } { verbose "Skipping $testfile.exp" return } > + > +if { [prepare_for_testing $testfile.exp $testfile $srcfile] } { > + untested amd64-stap-optional-prefix.exp > + return -1 > +} Here too. But, prepare_for_testing already calls untested for you, using the text passed as first argument. Write: if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { return -1 } > + > +# Run to the first probe (foo). > + > +if { ![runto "-pstap foo"] } { > + fail "run to probe foo" > + return > +} > + > +# Probe foo's first argument must me == $rsp s/me/be ? I think you meant: # Probe foo's first argument must be == ($rsp) Might even make it easier to read to spell that out in plain English. Otherwise this looks good to me. -- Pedro Alves