From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30155 invoked by alias); 30 Apr 2014 13:18:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30142 invoked by uid 89); 30 Apr 2014 13:18:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-gw2-out.broadcom.com Received: from mail-gw2-out.broadcom.com (HELO mail-gw2-out.broadcom.com) (216.31.210.63) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Apr 2014 13:18:54 +0000 Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw2-out.broadcom.com with ESMTP; 30 Apr 2014 06:44:13 -0700 Received: from IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 30 Apr 2014 06:18:52 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) with Microsoft SMTP Server id 14.3.174.1; Wed, 30 Apr 2014 06:18:53 -0700 Received: from [10.177.72.87] (unknown [10.177.72.87]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id C118E51E7F; Wed, 30 Apr 2014 06:18:52 -0700 (PDT) Message-ID: <5360F83B.4090203@broadcom.com> Date: Wed, 30 Apr 2014 13:18:00 -0000 From: Andrew Burgess User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: CC: Tom Tromey Subject: Re: [PATCH] rename "set debugvarobj" to "set debug varobj" References: <1398785790-2059-1-git-send-email-tromey@redhat.com> In-Reply-To: <1398785790-2059-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00639.txt.bz2 On 29/04/2014 4:36 PM, Tom Tromey wrote: > +++ b/gdb/varobj.c > @@ -2795,17 +2795,18 @@ void > _initialize_varobj (void) > { > int sizeof_table = sizeof (struct vlist *) * VAROBJ_TABLE_SIZE; > + struct cmd_list_element *c; I don't think this extra line is needed. Cheers, Andrew > varobj_table = xmalloc (sizeof_table); > memset (varobj_table, 0, sizeof_table); > > - add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance, > + add_setshow_zuinteger_cmd ("varobj", class_maintenance, > &varobjdebug, > _("Set varobj debugging."), > _("Show varobj debugging."), > _("When non-zero, varobj debugging is enabled."), > NULL, show_varobjdebug, > - &setlist, &showlist); > + &setdebuglist, &showdebuglist); > } > > /* Invalidate varobj VAR if it is tied to locals and re-create it if it is >