From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LpfoOVyq5GXcejYAWB0awg (envelope-from ) for ; Sun, 03 Mar 2024 11:50:36 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=lancelotsix.com header.i=@lancelotsix.com header.a=rsa-sha256 header.s=2021 header.b=LbcE/civ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E13151E0D2; Sun, 3 Mar 2024 11:50:36 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4AE411E092 for ; Sun, 3 Mar 2024 11:50:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F5E53858C33 for ; Sun, 3 Mar 2024 16:50:33 +0000 (GMT) Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 8E94B3858C55 for ; Sun, 3 Mar 2024 16:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E94B3858C55 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E94B3858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709484618; cv=none; b=W8/iEHVE6PgR9IxD3mBSYpEXUVGdJ9wTQtcsLEvc1XYtI/B2FGgYSwGf9UqUbHieWJB7o3sgAEk2UCJkIu1IMqfVeYSWNZMJgfB3YCFTROsbZ/Y+Re1x3qAyNW2yVxgui+hoKrYKPJnkyUcXL8aBYX1+Q3JigcBEw4quhjeH4lo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709484618; c=relaxed/simple; bh=hWMM9gcvr6Gcfrjz49EVBc4j0+cT7BoMb9f8trJlo2o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w31gcl7ISbpTCVk6GhSHINI2l+/FKYZtGPA3TmL60+bP9/Y+P2rCAyX91BZ9uKVyVb9E13FwAHi4w/Yie3JcbNwE14WjAaqW/umsTz8BCLGKvgmEDGZB6oRlqEf6hhejbWRM7C/lvlh/M8edPpS9II5LUQuOJ18tuG4/cIc34QI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [192.168.111.116] (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 4B8F68E0DB; Sun, 3 Mar 2024 16:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1709484615; bh=hWMM9gcvr6Gcfrjz49EVBc4j0+cT7BoMb9f8trJlo2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LbcE/civAGu9KjXGzI8gMJoqqNHs09vt0JlcPqtcjSksJA8xZFjhaA52eLFZaZoeA ht5Yqy+/VNlves8v1SPC09rgtrvy0KYgW1tu2lCs8cnhTtce8ztoDksZ3Ukkd+1WQd lRXaJovcbhUgyfE9fVVws4ibhxp2tXXxXUeXbekMdWXD2+D/wnRlQQC5Th4OBtonsH ajazCzzTkz7ZRaHLoRI30vjSP7d18q0XlPASL9jvaQd5ZkJeyejnNHFcYVEdXDpRZy tKCbCOGIXoT+NUvEmTYwIhk1k3Hnsh/FW2th0b06PLziAtpXIXwGKlJCVVGAtLwQhM +k77Awc3cs0/w== Message-ID: <535b9754-f25d-4a15-ae59-177126287ccb@lancelotsix.com> Date: Sun, 3 Mar 2024 16:50:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] Rewrite final cleanups Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240223-final-cleanups-v1-0-84d5271e9979@adacore.com> <20240223-final-cleanups-v1-1-84d5271e9979@adacore.com> <20240225223034.l6gnzbamvivyzuyu@octopus> <87msrnvyz4.fsf@tromey.com> <20240227140331.cavxavrv4uoz4cdr@octopus> <87edcxvmul.fsf@tromey.com> From: Lancelot SIX In-Reply-To: <87edcxvmul.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Sun, 03 Mar 2024 16:50:15 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 27/02/2024 17:27, Tom Tromey wrote: > Lancelot> My train of thought was > Lancelot> 1) This `system ("rm -rf ...")` could be replaced with > Lancelot> std::filesystem::remove_all > Lancelot> 2) At least one overload of remove_all can throw > Lancelot> 3) What would happen if a cleanup throws (either an existing one, or one > Lancelot> to change/introduce in the future). > > Makes sense. > > I filed a bug for this: > > https://sourceware.org/bugzilla/show_bug.cgi?id=31420 > > ... and also a C++17 meta-bug, and various C++17 to-do items I've > thought of in the past. Thanks for creating the tickets to track this! I have submitted https://sourceware.org/pipermail/gdb-patches/2024-March/206982.html to handle this ticket. Best, Lancelot.