Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <hui_zhu@mentor.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [PATCH] Make "set disassemble-next-line on" can work with DUMMY_FRAME, SIGTRAMP_FRAME and ARCH_FRAME
Date: Fri, 25 Apr 2014 04:55:00 -0000	[thread overview]
Message-ID: <5359EAB3.7060808@mentor.com> (raw)

When GDB debug DUMMY_FRAME, SIGTRAMP_FRAME and ARCH_FRAME, even if
"set disassemble-next-line on", it will not output the asm code:
(gdb) set disassemble-next-line on
(gdb) si
<signal handler called>
(gdb)
<signal handler called>
(gdb)
<signal handler called>

So make this patch make they can work together, it will become:
(gdb) si
<signal handler called>
=> 0xffffffff816bfb09 <int_with_check+0>:    65 48 8b 0c 25 c8 c7 00 
00    mov    %gs:0xc7c8,%rcx
(gdb)
<signal handler called>
=> 0xffffffff816bfb12 <int_with_check+9>:    48 81 e9 d8 1f 00 00   
  sub    $0x1fd8,%rcx
(gdb)
<signal handler called>
=> 0xffffffff816bfb19 <int_with_check+16>:    8b 51 10  mov    
0x10(%rcx),%edx

Thanks,
Hui

2014-04-25  Hui Zhu  <hui@codesourcery.com>

     * stack.c (print_frame_info): Call do_gdb_disassembly with
     DUMMY_FRAME, SIGTRAMP_FRAME and ARCH_FRAME.

--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -836,6 +836,13 @@ print_frame_info (struct frame_info *fra
        ui_out_text (uiout, "\n");
        annotate_frame_end ();

+      /* If disassemble-next-line is set to auto or on output the next
+     instruction.  */
+      if (disassemble_next_line == AUTO_BOOLEAN_AUTO
+      || disassemble_next_line == AUTO_BOOLEAN_TRUE)
+    do_gdb_disassembly (get_frame_arch (frame), 1,
+                get_frame_pc (frame), get_frame_pc (frame) + 1);
+
        do_cleanups (uiout_cleanup);
        return;
      }


             reply	other threads:[~2014-04-25  4:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  4:55 Hui Zhu [this message]
2014-04-25 19:46 ` Pedro Alves
2014-04-27 14:27   ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5359EAB3.7060808@mentor.com \
    --to=hui_zhu@mentor.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox