From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3643 invoked by alias); 24 Apr 2014 20:53:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3623 invoked by uid 89); 24 Apr 2014 20:53:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 20:53:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OKrceB006831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2014 16:53:38 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3OKrbQ4030179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 24 Apr 2014 16:53:38 -0400 Message-ID: <535979D1.50505@redhat.com> Date: Thu, 24 Apr 2014 20:53:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 11/12] Test case References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-12-git-send-email-yao@codesourcery.com> <53510FB3.1060202@codesourcery.com> In-Reply-To: <53510FB3.1060202@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00517.txt.bz2 On 04/18/2014 04:42 AM, Yao Qi wrote: > On 02/14/2014 04:44 PM, Yao Qi wrote: >> - Remove hard-coded breakpoint number, but it depends on this patch >> >> [PATCH] Accept convenience variable in commands -break-passcount and -break-commands >> https://sourceware.org/ml/gdb-patches/2014-01/msg00936.html > > This patch above isn't acceptable as its current shape, so I revert > this patch back to use hard-coded breakpoint number. > Yeah, I apologize for that. Something tells me we should consider extending the mi_create_breakpoint API to not only return the breakpoint regexp but also the number of the breakpoint that was set. That would make things like this quite a bit easier in the future. I really only have three (related) nits about this patch: In gdb.trace/mi-available-children-only-cxx.exp: +mi_gdb_test "-break-insert -a marker" "\\^done.*" \ + "trace marker" + and in gdb.trace/mi-available-children-only.exp: +mi_gdb_test "-break-insert -a marker1" "\\^done.*" \ + "trace marker1" [snip] +mi_gdb_test "-break-insert -a marker2" "\\^done.*" \ + "trace marker2" Please use mi_create_breakpoint unless there is some feature that is not supported by that API. Otherwise, this looks okay. I recommend a maintainer approve with these changes. Keith