From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 532 invoked by alias); 24 Apr 2014 20:50:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 521 invoked by uid 89); 24 Apr 2014 20:50:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 20:50:51 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OKom6l005932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2014 16:50:48 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3OKomaK011153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 24 Apr 2014 16:50:48 -0400 Message-ID: <53597927.6030301@redhat.com> Date: Thu, 24 Apr 2014 20:50:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 10/12] Match dynamic="1" in the output of -var-list-children References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-11-git-send-email-yao@codesourcery.com> In-Reply-To: <1392367471-13527-11-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00516.txt.bz2 On 02/14/2014 12:44 AM, Yao Qi wrote: > I am not satisfied with the regexp construction for each child in > mi_child_regexp. Welcome, like-minded contributor! :-) > will be rewritten to: > > mi_list_varobj_children "struct_declarations" { > {struct_declarations.integer integer 0 {type int}} > } "test" > > if we want to match "dynamic" attribute, we can write: > > mi_list_varobj_children "struct_declarations" { > {struct_declarations.integer integer 0 {type int dynamic 1}} > } "test" > > Since mi_list_varobj_children has been widely used in test suite, I'd > like to defer the change after this patch series. There are a number of different strategies for testing varobj in the test suite. Not too long ago, I added another which uses "trees" not altogether unlike what you are proposing. Have you looked into varobj_tree stuff in the test suite? Does it fit your needs? If so, it might be better to use this facility and (start to) deprecate the mi_list_varobj_children interface. > > V2: > - Remove empty 'else' block. > > gdb/testsuite: > > 2014-02-14 Yao Qi > > * lib/mi-support.exp (mi_child_regexp): Append 'dynamic="1"' to > children_exp. This looks okay to me; I recommend a maintainer approve this. Keith