From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11309 invoked by alias); 24 Apr 2014 11:33:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11282 invoked by uid 89); 24 Apr 2014 11:33:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 11:33:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OBXnYO026499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2014 07:33:50 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3OBXlBK031268; Thu, 24 Apr 2014 07:33:48 -0400 Message-ID: <5358F69A.5090504@redhat.com> Date: Thu, 24 Apr 2014 11:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Michael Sturm CC: palves@redhat.com, eliz@gnu.org, mark.kettenis@xs4all.nl, walfred.tedeschi@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH V5 1/3] Add AVX512 registers support to GDB. References: <1398258160-9070-1-git-send-email-michael.sturm@intel.com> <1398258160-9070-2-git-send-email-michael.sturm@intel.com> In-Reply-To: <1398258160-9070-2-git-send-email-michael.sturm@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-04/txt/msg00491.txt.bz2 On 04/23/2014 02:02 PM, Michael Sturm wrote: > + > +for { set r 0 } { $r < $nr_regs } { incr r } { > + set val [expr $r + 1] > + gdb_test "print/x k_data\[$r\]" \ > + ".. = 0x$val$val$val$val" \ > + "check contents of k_data\[$r\]" > + > +gdb_test "break [gdb_get_line_number "third breakpoint here"]" \ > + "Breakpoint .* at .*i386-avx512.c.*" \ > + "set third breakpoint in main" > +gdb_continue_to_breakpoint "continue to third breakpoint in main" > + This bit wasn't addressed -- indentation here and all the way through below still isn't right. Ah, actually, it's not really the indentation that is missing. It's a '}' to close the for loop above that is missing. So it looks like the "check contents of k_data\[$r\]" test is only running for $r == 0. Then the remainder of the tests don't actually run $nr_regs times, because there are other loops within that broken loop that also use $r as iterator: > +for { set r 0 } { $r < $nr_regs } { incr r } { > + gdb_test "print zmm_data\[$r\]" \ > + ".. = \\{f = \\{[expr $r + 30], [expr $r.125 + 30], [expr $r.25 + 20], [expr $r.375 + 20], [expr $r.5 + 10], [expr $r.625 + 10], [expr $r.75 + 10], [expr $r.875 + 10]\\}\\}.*" \ > + "check contents of zmm_data\[$r\] after writing XMM regs" > +} > + > +} > + This last "}" is closing the broken for loop. Seems to me it's misplaced. Other than that, looks fine to me. Please push with those issues fixed. -- Pedro Alves