From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111999-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2100 invoked by alias); 24 Apr 2014 10:42:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2043 invoked by uid 89); 24 Apr 2014 10:42:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 10:42:28 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OAgQNj022589	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Thu, 24 Apr 2014 06:42:26 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3OAgO8A028713;	Thu, 24 Apr 2014 06:42:25 -0400
Message-ID: <5358EA8F.3000601@redhat.com>
Date: Thu, 24 Apr 2014 10:42:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: David Blaikie <dblaikie@gmail.com>
CC: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info
References: <CAENS6EtFF4hPJe3uqJBkPf4q8c0n4RvV1_jO=6mWWEp=X2HbnA@mail.gmail.com>
In-Reply-To: <CAENS6EtFF4hPJe3uqJBkPf4q8c0n4RvV1_jO=6mWWEp=X2HbnA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-04/txt/msg00489.txt.bz2

Hi David,

On 04/14/2014 12:25 AM, David Blaikie wrote:
>  
> +if {[test_compiler_info {clang-*-*}]} {  setup_xfail clang/14500 *-*-* }
>  gdb_test "break here" \
>    "Breakpoint.*at.*" \
>    "breakpoint here"
>  
> +if {[test_compiler_info {clang-*-*}]} {  setup_xfail clang/14500 *-*-* }

A suggestion -- in these cases where we have a bunch of similar
setup_xfails for a single bug, it's good to do as e.g.,
gdb.cp/temargs.exp does.  That is, something like

set have_clang_14500_bug [test_compiler_info {clang-*-*}]

# Short description of bug here.
proc setup_xfail_clang_14500 {} {
  global have_clang_14500_bug

  if { $have_clang_14500_bug } {
     setup_xfail clang/14500 *-*-*
  }
}

And then:

+ setup_xfail_clang_14500
 gdb_test "break main:there" \
   "Breakpoint.*at.*" \
   "breakpoint there"

etc.

A style like that adds less clutter, and, is less typo prone than:

> +if {[test_compiler_info {clang-*-*}]} {  setup_xfail clang/14500 *-*-* }

all over.  And it's a single place to change the condition to be
dependent on clang version, in the future, if you want to.

-- 
Pedro Alves