From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17962 invoked by alias); 23 Apr 2014 19:29:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17951 invoked by uid 89); 23 Apr 2014 19:29:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 19:28:58 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NJSt8K027061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Apr 2014 15:28:55 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3NJSsTn010905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 23 Apr 2014 15:28:54 -0400 Message-ID: <53581476.8000205@redhat.com> Date: Wed, 23 Apr 2014 19:29:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 03/12] Iterate over 'struct varobj_item' instead of PyObject References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1392367471-13527-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00466.txt.bz2 On 02/14/2014 12:44 AM, Yao Qi wrote: > V2: > - Call varobj_delete_iter in free_variable. > - Fix changelog entries. > - Use XNEW. > > gdb: > > 2014-02-14 Pedro Alves > Yao Qi > > * python/py-varobj.c (py_varobj_iter_next): Move some code > from varobj.c. > * varobj-iter.h (struct varobj_item): Moved from varobj.c. > * varobj.c: Move "varobj-iter.h" inclusion earlier. > (struct varobj_item): Moved to varobj-iter.h". > (varobj_clear_saved_item): New function. > (update_dynamic_varobj_children): Move python-related code to > py-varobj.c. > (free_variable): Call varobj_clear_saved_item and > varobj_iter_delete. This looks okay to me. I recommend a maintainer give this a final review. Keith