From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13167 invoked by alias); 23 Apr 2014 19:24:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13153 invoked by uid 89); 23 Apr 2014 19:24:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 19:24:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NJOMMs027550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Apr 2014 15:24:22 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3NJOLoe001811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 23 Apr 2014 15:24:22 -0400 Message-ID: <53581365.2050005@redhat.com> Date: Wed, 23 Apr 2014 19:24:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 02/12] Generalize varobj iterator References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1392367471-13527-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00464.txt.bz2 On 02/14/2014 12:44 AM, Yao Qi wrote: > V2: > - Fix a missing cleanup. > - Fix typos. > - Use XNEW. > - Check against NULL explicitly. > - Update copyright year for new added files. > > gdb: > > 2014-02-14 Pedro Alves > Yao Qi > > * Makefile.in (SUBDIR_PYTHON_OBS): Add "py-varobj.o". > (SUBDIR_PYTHON_SRCS): Add "python/py-varobj.c". > (HFILES_NO_SRCDIR): Add "varobj-iter.h". > (py-varobj.o): New rule. > * python/py-varobj.c: New file. > * python/python-internal.h (py_varobj_get_iterator): Declare. > * varobj-iter.h: New file. > * varobj.c: Include "varobj-iter.h" > (struct varobj) : Change its type from "PyObject *" > to "struct varobj_iter *". > : Likewise. > [HAVE_PYTHON] (varobj_ensure_python_env): Make it extern. > [HAVE_PYTHON] (varobj_get_iterator): New function. > (update_dynamic_varobj_children) [HAVE_PYTHON]: Move > python-specific code to python/py-varobj.c. > (install_visualizer): Call varobj_iter_delete instead of > Py_XDECREF. > * varobj.h (varobj_ensure_python_env): Declare. This looks okay to me, too. I recommend a maintainer give this a final review. Keith