From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29314 invoked by alias); 23 Apr 2014 18:16:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29303 invoked by uid 89); 23 Apr 2014 18:16:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 18:16:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NIGFGd020658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Apr 2014 14:16:15 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3NIGEv6031531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 23 Apr 2014 14:16:15 -0400 Message-ID: <5358036E.1090901@redhat.com> Date: Wed, 23 Apr 2014 18:16:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 01/12] Use 'struct varobj_item' to represent name and value pair References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1392367471-13527-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00458.txt.bz2 On 02/14/2014 12:44 AM, Yao Qi wrote: > V2: > - Fix changelog entry. > - Fix one grammatical mistake. > > gdb: > > 2014-02-14 Yao Qi > > * varobj.c (struct varobj_item): New structure. > (create_child_with_value): Update declaration. > (varobj_add_child): Replace arguments 'name' and 'value' with > 'item'. All callers updated. > (install_dynamic_child): Likewise. > (update_dynamic_varobj_children): Likewise. > (varobj_add_child): Likewise. > (create_child_with_value): Likewise. This looks good to me. I recommend a maintainer look this over for final review/approval. Keith