From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: [RFA/testsuite] Remove unused globals from mi-break.exp
Date: Tue, 15 Apr 2014 15:48:00 -0000 [thread overview]
Message-ID: <534D54AF.3010501@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
Hi,
In a recent email, I asked a contributor to help cleanup some
ridiculously long expect regexps.
Eating my own dog food, I am going to be submitting some new MI
functions which will facilitate regexp construction for breakpoints.
This patch simply removes a bunch of unused globals from mi-break.exp.
Keith
2014-04-15 Keith Seitz <keiths@redhat.com>
* gdb.mi/mi-break.exp (test_tbreak_creation_and_listing): Remove
unused globals.
(test_rbreak_creation_and_listing): Likewise.
(test_ignore_count): Likewise.
(test_error): Likewise.
[-- Attachment #2: mi-break.exp-remove-unused-globals.patch --]
[-- Type: text/x-patch, Size: 2177 bytes --]
diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp
index a9064fd..04dd932 100644
--- a/gdb/testsuite/gdb.mi/mi-break.exp
+++ b/gdb/testsuite/gdb.mi/mi-break.exp
@@ -56,14 +56,12 @@ set line_callme_body [expr $line_callme_head + 2]
set fullname "fullname=\"${fullname_syntax}${srcfile}\""
proc test_tbreak_creation_and_listing {} {
- global mi_gdb_prompt
global srcfile
global hex
- global line_callee4_head line_callee4_body
- global line_callee3_head line_callee3_body
- global line_callee2_head line_callee2_body
- global line_callee1_head line_callee1_body
- global line_main_head line_main_body
+ global line_callee4_head
+ global line_callee3_head
+ global line_callee2_body
+ global line_main_body
global fullname
# Insert some breakpoints and list them
@@ -98,14 +96,12 @@ proc test_tbreak_creation_and_listing {} {
}
proc test_rbreak_creation_and_listing {} {
- global mi_gdb_prompt
- global srcfile
global hex
- global line_callee4_head line_callee4_body
- global line_callee3_head line_callee3_body
- global line_callee2_head line_callee2_body
- global line_callee1_head line_callee1_body
- global line_main_head line_main_body
+ global line_callee4_body
+ global line_callee3_body
+ global line_callee2_body
+ global line_callee1_body
+ global line_main_body
# Insert some breakpoints and list them
# Also, disable some so they do not interfere with other tests
@@ -165,7 +161,6 @@ proc test_abreak_creation {} {
}
proc test_ignore_count {} {
- global mi_gdb_prompt
global line_callme_body
mi_gdb_test "-break-insert -i 1 callme" \
@@ -179,8 +174,6 @@ proc test_ignore_count {} {
}
proc test_error {} {
- global mi_gdb_prompt
-
mi_gdb_test "-break-insert function_that_does_not_exist" \
".*\\^error,msg=\"Function \\\\\"function_that_does_not_exist\\\\\" not defined.\"" \
"breakpoint at nonexistent function"
@@ -211,7 +204,6 @@ proc test_error {} {
}
proc test_disabled_creation {} {
- global mi_gdb_prompt
global hex
global line_callee2_body
next reply other threads:[~2014-04-15 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 15:48 Keith Seitz [this message]
2014-04-15 18:26 ` Pedro Alves
2014-04-15 18:49 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D54AF.3010501@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox