From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [pushed] Make sym-file.exp work with remote targets and hosts.
Date: Tue, 15 Apr 2014 13:19:00 -0000 [thread overview]
Message-ID: <534D31C0.3090403@redhat.com> (raw)
In-Reply-To: <008401cf58a9$cd7c33a0$68749ae0$@muller@ics-cnrs.unistra.fr>
On 04/15/2014 01:54 PM, Pierre Muller wrote:
> Hi Pedro,
>
> I spotted a small typo error below ...
>>
>> +#ifdef __linux__
>> +# define SELF_LINK "/proc/self/exe"
>> +#elif defined NETBSD
>> +# define SELK_LINK "/proc/curproc/exe"
>> +#elif defined __OpenBSD__ || defined __FreeBSD__ || defined
>> __DragonFly__
>> +# define SELK_LINK "/proc/curproc/file"
>> +#elif defined SunOS
>> +# define SELK_LINK "/proc/self/path/a.out"
>> +#endif
>
> SELK_LINK => SELF_LINK
Thanks Pierre. Fixed, as below.
---------------
[PATCH] gdb.base/sym-file-loader.c: Fix typo.
SELF_LINK, not SELK_LINK...
gdb/testsuite/
2014-04-15 Pedro Alves <palves@redhat.com>
* gdb.base/sym-file-loader.c: Fix typo. SELF_LINK, not SELK_LINK.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/sym-file-loader.c | 6 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 64e4cbd..ca002e9 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2014-04-15 Pedro Alves <palves@redhat.com>
+ * gdb.base/sym-file-loader.c: Fix typo. SELF_LINK, not SELK_LINK.
+
+2014-04-15 Pedro Alves <palves@redhat.com>
+
* gdb.base/sym-file-loader.c: Include <limits.h>.
(SELF_LINK): New define.
(get_origin): New function.
diff --git a/gdb/testsuite/gdb.base/sym-file-loader.c b/gdb/testsuite/gdb.base/sym-file-loader.c
index 625788a..c30ffe1 100644
--- a/gdb/testsuite/gdb.base/sym-file-loader.c
+++ b/gdb/testsuite/gdb.base/sym-file-loader.c
@@ -81,11 +81,11 @@ load (uint8_t *addr, Elf_External_Phdr *phdr, struct segment *tail_seg)
#ifdef __linux__
# define SELF_LINK "/proc/self/exe"
#elif defined NETBSD
-# define SELK_LINK "/proc/curproc/exe"
+# define SELF_LINK "/proc/curproc/exe"
#elif defined __OpenBSD__ || defined __FreeBSD__ || defined __DragonFly__
-# define SELK_LINK "/proc/curproc/file"
+# define SELF_LINK "/proc/curproc/file"
#elif defined SunOS
-# define SELK_LINK "/proc/self/path/a.out"
+# define SELF_LINK "/proc/self/path/a.out"
#endif
/* Like RPATH=$ORIGIN, return the dirname of the current
--
1.7.11.7
prev parent reply other threads:[~2014-04-15 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 12:38 Pedro Alves
[not found] ` <008401cf58a9$cd7c33a0$68749ae0$@muller@ics-cnrs.unistra.fr>
2014-04-15 13:19 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D31C0.3090403@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox