Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pierre Langlois <pierre.langlois@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix erroneous backtrace on avrxmega architectures.
Date: Tue, 08 Apr 2014 14:30:00 -0000	[thread overview]
Message-ID: <53440806.4000302@embecosm.com> (raw)

Hi all,

This patch adds avrxmega architectures to GDB, as given by bfd_architecture,
when setting call_length. This is the length of an address pushed on the stack
by a call instruction.

It was incorrect on avrxmega devices with more than 128k of memory (tested on
the atxmega256a3bu), which would break stack-unwinding.

Best,

Pierre

2014-04-08  Pierre Langlois  <pierre.langlois@embecosm.com>

	* avr-tdep.c (struct gdbarch_tdep): Mention avrxmega in the comment.
	(avr_gdbarch_init): Add xmega architectures given by bfd_architecture
	when setting the size of call_length.
---
  gdb/avr-tdep.c | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c
index 7fb16d1..9b0bfaf 100644
--- a/gdb/avr-tdep.c
+++ b/gdb/avr-tdep.c
@@ -180,7 +180,7 @@ struct avr_unwind_cache
  struct gdbarch_tdep
  {
    /* Number of bytes stored to the stack by call instructions.
-     2 bytes for avr1-5, 3 bytes for avr6.  */
+     2 bytes for avr1-5 and avrxmega1-5, 3 bytes for avr6 and avrxmega6-7.  */
    int call_length;
  
    /* Type for void.  */
@@ -1356,14 +1356,21 @@ avr_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
    switch (info.bfd_arch_info->mach)
      {
      case bfd_mach_avr1:
+    case bfd_mach_avrxmega1:
      case bfd_mach_avr2:
+    case bfd_mach_avrxmega2:
      case bfd_mach_avr3:
+    case bfd_mach_avrxmega3:
      case bfd_mach_avr4:
+    case bfd_mach_avrxmega4:
      case bfd_mach_avr5:
+    case bfd_mach_avrxmega5:
      default:
        call_length = 2;
        break;
      case bfd_mach_avr6:
+    case bfd_mach_avrxmega6:
+    case bfd_mach_avrxmega7:
        call_length = 3;
        break;
      }
-- 
1.9.1


             reply	other threads:[~2014-04-08 14:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 14:30 Pierre Langlois [this message]
2014-04-08 14:49 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53440806.4000302@embecosm.com \
    --to=pierre.langlois@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox