From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qOGjBCvYZWcRfiUAWB0awg (envelope-from ) for ; Fri, 20 Dec 2024 15:48:43 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dd0oJA5N; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0FAC21E097; Fri, 20 Dec 2024 15:48:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BB7251E091 for ; Fri, 20 Dec 2024 15:48:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 65EA13858D38 for ; Fri, 20 Dec 2024 20:48:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65EA13858D38 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dd0oJA5N Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7FB933858D38 for ; Fri, 20 Dec 2024 20:47:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FB933858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FB933858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734727678; cv=none; b=fRmEKXoTyddSxB1Ng50BL1Kaa8PyzRR+piDBJb0gzPpFMiheWmdGHO3UANoTfrDwi/HdKntJ6NYFXZztpqB3qeyOp8stdZhtF9ouS2pK5Nft1bgHPsCgoLcyB2WqW+6GXAQf2xXBykxkanjcfYB3KNuu0bQV8WqEFRU10uMtDmc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734727678; c=relaxed/simple; bh=JV9d8wbSjvqnPT/w0ks5ovAMSHEFcJEWfUiVUwUJQTU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mALePbQ/GrwznVInkDwoVaIWX+BwnPSZ0DN4DeRhAzurM4CGfj9icWyeRyWEce0d42T8QxxwBIWA6LUcuHdSomjv65gFYvd1Dq8LiUjJWKBGlxKdIbPLVl3hZ0PTRb79hCC3Z6yBw/2xhvxlTGYO5R2BPSniXf1fxBQeYgzYlmc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FB933858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734727678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GYGulV6x7M0cQZLkzmivlPQxeVLFdz2HiPZuQ7z+gN0=; b=dd0oJA5Nrd0kpS0IhX6Blab3lwrePngVjMcqgMm9ZcIBYCmxI73n++JY7vo+0fm45KqNwd mqPpv0Ob967BMWjDQmuocNI9sy/sg8eLdDy26XmUY+vSVuOcNuptnLOLK4M5z06PHSwfxw OiQSladLR1/lSPPNqzY/7g63OfxgctY= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-bT7kr2APPvG7gF0S1Hx4DA-1; Fri, 20 Dec 2024 15:47:57 -0500 X-MC-Unique: bT7kr2APPvG7gF0S1Hx4DA-1 X-Mimecast-MFC-AGG-ID: bT7kr2APPvG7gF0S1Hx4DA Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-21655569152so20177125ad.2 for ; Fri, 20 Dec 2024 12:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734727676; x=1735332476; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GYGulV6x7M0cQZLkzmivlPQxeVLFdz2HiPZuQ7z+gN0=; b=qYSPWbXRH3zw973TzrmYJTstCbGtAazvJ0+1+dUUpi6rGH8W9d2OhdIaiYYrVmTrzy X0wOTapvLSz5GpG1t2cCD/x1z0/55//k38l1p3ZMfSZogUW9Y9TG0AcYxsdaBGwKFoiM CZ8WWXET3cPCltHLsgcmbR0ojGipP4QdNQa++U0SJct0xLBsDN+EIurYLdkU1rMeLE/g rVmq2vIVvaDCGiVBF9EEfkAYg2NwoOERGwVvRQFfW0f3sd+8FvkaDAVbw2AoOFT4L3so OhQWJEVPNbjQGH77ZeB5c1o3Oy23qolPw9/0lJY2Lvad09KP4px86Ba96qSFphOAJVjE V71A== X-Gm-Message-State: AOJu0YwlkGwhA1ElsSqWAgZiKFhB598TMEWs9lHKgbOjt8AG/i54fJdK cc26JhduUYxIAO0GXNeooQJQCXhKy8e6KV35SISi5Bzv/aF0jq59WflnzF8BUUEr1aulvKOjo4m 7i0WYtwn+iAKA6Jsfzdbpq1OtAuBMOXtMRImwle1LSZblyOvquYZPamJtHNi6HTxsOSBn24nGAf lR7Izs+OUYetHipUC7tdP2yfkFRgAf8Gbq0Srzhjzo X-Gm-Gg: ASbGncvRGBsGLrU3xkkjXylpwRpc9zigSJ11ssrJRpfD3QOgTh70ZRny+azLdVCc2X4 NSBEqBPXRLEzGpIWDnmXVZ0XLroXvKM0O5LMKH+MHdX/gEvA9hcfuWsWnp07NC5Of87bOgFGpJj Q3S3VKQYjjXgAed76E1FfoVMMVMiYczzbCm/gpqK57+VRJX3uxi/28w8BQQgK4GV8fl3EsUzZYU WY1wGhjwuJ8DoDDhAJ5epqgrYCK2sLl7Tiwm7+meFrQd/Mz6qoq+LwQJGMHDA== X-Received: by 2002:a17:902:d502:b0:216:31c2:3db8 with SMTP id d9443c01a7336-219e70c01admr54284265ad.37.1734727675904; Fri, 20 Dec 2024 12:47:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhTheo7kqfDKXmqjZlBFF93bph3V7h+pPvmpk6ttDos5FLkbEAXKDgY9OwLNq0FGA/ksmDXw== X-Received: by 2002:a17:902:d502:b0:216:31c2:3db8 with SMTP id d9443c01a7336-219e70c01admr54284025ad.37.1734727675477; Fri, 20 Dec 2024 12:47:55 -0800 (PST) Received: from [150.1.200.127] ([172.56.107.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e585sm33210535ad.70.2024.12.20.12.47.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 12:47:55 -0800 (PST) Message-ID: <534184fe-882b-46cd-bb1c-a1b827f96172@redhat.com> Date: Fri, 20 Dec 2024 12:47:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Add gstack script To: gdb-patches@sourceware.org References: <860d6cddca679b87e6314db0cfb6ab00e01d46ff.1734542644.git.keiths@redhat.com> <87v7ve8h5b.fsf@tromey.com> <87msgq6wid.fsf@tromey.com> From: Keith Seitz In-Reply-To: <87msgq6wid.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7M2qlWZT6MKXisjRbp_DQskL-GbM3wrgMf8MAZ84fUQ_1734727676 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/20/24 10:26 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> Thank you for the review, but there's one little snafu: > Keith> Linaro CI apparently does not have any awk program installed > Keith> when running tests and flagged a new failure from gstack.exp: > > Keith> There are some tests which unconditionally use "gawk" (such as > Keith> gdb.base/gnu-debugdata.exp), so I've chosen to address this > Keith> failure by using the following patch: > ... > > Keith> Please let me know if this is still acceptable. > > Looks good to me. Thank you, Tom & Eli for your reviews. I've pushed this. Keith