From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id v18KBu4XNWD4egAAWB0awg (envelope-from ) for ; Tue, 23 Feb 2021 09:57:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 0B0441EF78; Tue, 23 Feb 2021 09:57:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA2E61E590 for ; Tue, 23 Feb 2021 09:57:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 520EC383443E; Tue, 23 Feb 2021 14:57:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 520EC383443E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614092269; bh=Pc0WFOl5j/bnjCllVckngUFIpHcceWkPhSLpEMO8UBs=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gE9i0k2zwH14YcIFQoI35SXEJn6WVqUaK5bRSOqi77Hcy7Uy1rAff7Gt1XOgrIlXo I+fAlliWQcX/G+c59LXlIgMCNvhq3Nwxm1Z/rutgcAHYZi4kDyjx6rcAiucOzrnSTC iHpDWhC7wT2/p2f//75XtQTkY7p84HeCHafZ92/w= Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) by sourceware.org (Postfix) with ESMTPS id 0AA4D3870851 for ; Tue, 23 Feb 2021 14:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0AA4D3870851 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqRmmlUxE5ychzKWLj6CJeuj0QbExGE+/qk29GUHR7HCOGyv53XVrem0ojCllBq2dQnV6hrB1YMnrqJk7y/OoIZBl8w4z6oa3r86O42D3iPdJtJGrtsw1+wSlPGO3mVnKfub+cB3CFvD1l8T0Xr2+mQuMbQX/50nTLaCUW6fdpSjNu4AEpUGIZ3xarK2f6ZxUmeJenUgAV83Hvsi4v7yRZLa42KXRsD9NV/L3BV4rGlXdkPbSJmQItqReps3UM19OGXh2VAdrd+Xz2jxHHr1dsxaKJ4JSti6bm9JUwDc0CuLOx0XHFs0MkFkS3eKaB/thTmDeeYnLEyQ4EBKKMpa5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pc0WFOl5j/bnjCllVckngUFIpHcceWkPhSLpEMO8UBs=; b=MUDx5AN3wxRLBjzaxGWRwogXp/M4kdcHeLtu+PcPHY+1hezxDrkEF4hjsdz1rwdJtgH2YD+p5ClvOCXa1buo3krhKqEiZMAVI4ItcExyD1kgGDeOBEkvZyc/gRBLbcTMe8E3dq03p6UdFqlLvDItrJV5NJ4b+6xyl44ACxAk3M1ylekX201L5hGvBVd3/FJNyrRBdprTcVfSbk5g5JfeoGEMXbfJ7yxFfdbuJ6ivkkOHlscMuCdjm7kHsKb7D7kRyfM340pYGq5nYpfFNeixqzS4P0l+xPA/XywN3x+CEC8g7cyvn54JRTv38vUzz9xsht9HPi+biaypZYQ77yuu0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR12MB1932.namprd12.prod.outlook.com (2603:10b6:3:10e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Tue, 23 Feb 2021 14:57:45 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 14:57:45 +0000 Subject: Re: [PATCH 18/30] Add new classes that model DWARF stack element To: Tom Tromey References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-19-Zoran.Zaric@amd.com> <87blcudy4c.fsf@tromey.com> <877dnhashm.fsf@tromey.com> <87tuql9cgn.fsf@tromey.com> <8f4e14d8-4ed8-1ae6-9eed-a1b82e4688b8@amd.com> Message-ID: <533deb5a-7a44-b2dd-1336-069e935ea911@amd.com> Date: Tue, 23 Feb 2021 14:57:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <8f4e14d8-4ed8-1ae6-9eed-a1b82e4688b8@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [2a00:23c7:5a85:6801:3c68:1988:3c97:9289] X-ClientProxiedBy: LO2P265CA0276.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::24) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:3c68:1988:3c97:9289] (2a00:23c7:5a85:6801:3c68:1988:3c97:9289) by LO2P265CA0276.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.30 via Frontend Transport; Tue, 23 Feb 2021 14:57:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: efa05713-fa43-4b17-0512-08d8d80b60a8 X-MS-TrafficTypeDiagnostic: DM5PR12MB1932: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yAlabHvA4y58g+bIWzjElWl5vliZuFz5+51GRxJdk1o0VEOxadYtV0cArrJ57kDr5LSC6w9k4YFO4Ypm9sRs4vgBevquC96s82Wnluigzc2ERXSpcGiTV+uzP91qesAVNHPu8s9wH/CWEQO1dbgJ66b84B/zqtv25WMRKSHXKzas9zLdgCDckGUQmWp1g7HcCLqjBfX1r5VdytC4LtVvAEaqsRxfmsXTBX5EtMKi0pCVDHLR9zTHehylM1OUW92PcXfZLeN6+FxgGAiNyx0ht0VFC7hHiNCMyEnVB+LwhNJUk4MguoNNrYQ9rJ2rfMvUQnFvvNL9QG5gjbnNZYno8wqWrbS0deGRkoAhbFAtaWni0TXu9UaSkKwgbuIVZSsc+fjoOrGORwcZZ0q3BG/6+452MZLivbxGSn+uaVgPwtbdNg62FLsEhR8hQpoDVwU8/UvGqbl56SqvIiziCLOnO+LlKeWEZjCSq6cilgHFxIx/U5Sus2lPwuF6svi2tRx/ll5C0cdCXR0wVAn4sG6N7rKa3sGqXPea6mYIRzctoopWcwbucBZXMZ0mC4o3m8hFWUzUhMFuQa6BMUhyWgMTXbuf5PHWwxvsXRYUz85iHv4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(66476007)(66556008)(66946007)(6916009)(6666004)(4326008)(5660300002)(478600001)(2906002)(31696002)(316002)(8936002)(6486002)(16526019)(2616005)(83380400001)(36756003)(8676002)(86362001)(31686004)(52116002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WFRtWFZUYk0renNQK1ZCaExrK3JXaU1RS3dwMFZyS24xRmRub3dwTzl0RVlP?= =?utf-8?B?bEwrYk9mN00xVHN5YUI3UmpKbzlUR0NxM0psQS9Od2ttdDFxSmYrUXBPbjM0?= =?utf-8?B?M3dXTW11bUNpSm5MZHFDYzBNMTMwT0hPVjZhSkk1Snp3c0lzb1Jocys3bWFT?= =?utf-8?B?Nno0cVo3Tll2aGlVWUNSWVAzdlR2VjFxZktiaTRINlNQdE02VW9nNm02Y3lD?= =?utf-8?B?MTQ1OEpZeWMzVEpyaHZlSW85cUpndXIyUmpuVGV3WHFiZW5GUnA2MmdrWTJ0?= =?utf-8?B?ZkJMWW1BMStNVGNtSit2SmxUVWROYVVGRTlzZzJhRWk4TzZYaHZ5dzkrNy9k?= =?utf-8?B?SEZDNFpsZXVHa0VxUEY3R2RTZS9VbUFWblAxVWFUbFlsOEkyZTBVR3RNUU4v?= =?utf-8?B?N002YjBRZUVuM1VMTnZ2bVhSMDhwSjJ2SWlvTlNzVXF1eE14aERmR3F6KzU2?= =?utf-8?B?YVhuR0J5K1RBYUx1Q2ptc0JtUHc0RjZuZGd4c0xuZHUzejhLam8wOFhxNmVX?= =?utf-8?B?aVN6TFFBazM3cGJxbzkvMUtVOEl1ZzhKQnQ3RzRuckJaSDgwRENqNVNLVUxn?= =?utf-8?B?K3NZamlPclZOUmVLY1RPMFJONFQ0anhzSEVwQ1ZBcm1DV3htMjBobERQeUF6?= =?utf-8?B?OENxTkV1WjVlYkRjOTFSOUZKZUc5cGhGejN3M1VSMzN4RHNmZ2tNZFBIV2NL?= =?utf-8?B?VjZoVThxbXdZdEdCUS9Qb3FzdUxiSGpOaG1kVm1kTTdiRUdvZDRZV3kvYWhx?= =?utf-8?B?aUdzRDdLMFhCcDVqMTJEa25RZFp4SU0rdmRBTGVEc2RqdGp6bkM3WTZIMTFE?= =?utf-8?B?UjZVV0pyYS9NdlB4emtDM2ZEY1VWUk1IN2xVRUdHNi9BLzltbm4rZlQvR0Ri?= =?utf-8?B?VlFQOU90YWJKa0NzVC90bXEyRXp4TGZIVnJkYy9iMUtFYXZvaHNaZmZvczFl?= =?utf-8?B?a25GQzdYUFgyVHFuN0RJRzlCV3NvczdaRmpZZWhRelM1Q3ZjS1daY1lnejNn?= =?utf-8?B?TDBwMWhndXJCdWFGNjdEa2tBSmsyRWZBSmlRZml5NUg1MVVmdFFYWFdlU05V?= =?utf-8?B?dVVqWWE2RE1CazNSYnJvdFVTdjRHODlId1ZHc05SOHZhQjBjMk1BUDVwTmFi?= =?utf-8?B?RE5Qd1kyU01RMzA0VmtUcnUrWGlYYXJPVDgvWTR6NFpzam1Ca2xHZjVFTzVW?= =?utf-8?B?ZlF6enRObWQ2MFpNdXRoczRvTFpxMkxaVDg3TERiUCtna21sS0Q2clBJNnIz?= =?utf-8?B?dzlZbWVsUHNVT2xSZE4rMHJnTFNxd2xtc2U1N2F5bTVGOWptd2xJcENSeFRK?= =?utf-8?B?ZHhVVkhTMVpYam9wZmZISnpmL3huRXpFdmRqNmlEdGVzZjgrQTF6OUJVYVIx?= =?utf-8?B?bHRZNG4zSzZ6aGZFUXkydEJEdmVWSExPMnh0NHFndEsrbTNMOGFXMi9ZTjE2?= =?utf-8?B?aXhqOEM1d1BJbE5KSi9kSkowa1BET3dla2ZGQ0s0OWRXc05HMzYrSEVBbnpI?= =?utf-8?B?bWZYR3NUUXVxQ2xWeWN6ajFWRlNzT2xVaVl0TmhjZ0hvZFJzV28zWVFKZDd6?= =?utf-8?B?YklvMTFnUDdhbTg0MEVqSWxyTm1YK01vWGlTVjZkTXVrV0g5V2NNcjRXOE5q?= =?utf-8?B?bWV1eDVWWTlzbDFnRUxRTmtNVGh0Q1NwVzZyZEYzVzcrMUJISnI4WkthZWRr?= =?utf-8?B?d0EvYjNuMFE1L3U5am4yY0xUTVU0ZVE0UmhPenNjTzNFY1F1N01ERVBUMjRC?= =?utf-8?B?dm5vY1lTLzU0UkdoVHBYc054Z3EvWDJwZ0poTUJtS1dNV285d3Vaa3Rac1hH?= =?utf-8?B?S2dFcEc5Q0Nma2JINjB0RWdLMTRzVXdqa2pqNE5nak9Fb09WcDkwci93ZVFF?= =?utf-8?Q?+5Z8SFByK9UJQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: efa05713-fa43-4b17-0512-08d8d80b60a8 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 14:57:45.3227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4rcu58sinzlz09Nv04vfsHV5ghuZVfZr26nB/yF4mZb3PO97VMbwLuSK8RRttHNsj1znutEhIqGKH9eflANn0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1932 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Zoran Zaric via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > >> >> Maybe you should just be using shared_ptr anyway. > > I really need to make another pass and make everything work with > shared_ptr. The reason why I didn't do that in the first place was > because I didn't notice smart pointers being used a lot around the code > and even less so in the code that I was replacing. In the new patch set, the implementation is now completely changed to use shared pointers. > >> Though to reiterate: >> >> Tom> It would still be good to understand why reference counting is >> needed >> Tom> here though.  That part still doesn't make sense to me. >> >> thanks, >> Tom >> > > The reference counting is there because in the extensions that we are > proposing there is a concept of nested composites and composites that > are not completed. > After the shared pointers switch, the only part that still uses the reference counting is the closure class for the computed struct value object support. Unfortunately, this cant be changed without a bigger change of how those computed struct value callbacks work and I feel that is outside of the scope of this patch set. Zoran