Re: [PATCH v3 3/4] Deprecate frame_stop_reason_string.

Pedro Alves
2014-05-29T09:56:40Z

On 05/29/2014 10:52 AM, Andrew Burgess wrote:
> On 29/05/2014 10:00 AM, Pedro Alves wrote:

>> This still has "frame" in the name, and misses the "to". Any reason for that?
>
> No, just me being special :)

LOL!

> This function is confusingly named, the "frame_" in the name implies it
> somehow is frame dependent, when in reality the function just converts an
> 'enum unwind_stop_reason' value to a string.

Excellent and concise description/log.

>
> gdb/ChangeLog:
>
> * frame.c (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * frame.h (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * stack.c (frame_info): Update call to frame_stop_reason_string.
> (backtrace_command_1): Likewise.
> * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise.
> * python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise.

OK

Thanks,
Pedro Alves