From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26161 invoked by alias); 4 Apr 2014 02:00:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26082 invoked by uid 89); 4 Apr 2014 01:59:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Apr 2014 01:59:58 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WVtQB-0003NM-4p from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 03 Apr 2014 18:59:55 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 3 Apr 2014 18:59:55 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Thu, 3 Apr 2014 18:59:54 -0700 Message-ID: <533E119E.5090401@codesourcery.com> Date: Fri, 04 Apr 2014 02:00:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [RFC 00/12 V2] Visit varobj available children only in MI References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <5327A296.3050605@codesourcery.com> In-Reply-To: <5327A296.3050605@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00053.txt.bz2 On 03/18/2014 09:34 AM, Yao Qi wrote: > On 02/14/2014 04:44 PM, Yao Qi wrote: >> This is the V2 of this patch series, addressing Keith's review comments >> to V1 (reviewed in Jan 2014). The general description of this series >> can be found https://sourceware.org/ml/gdb-patches/2013-11/msg00739.html >> >> Changes in V2 are: >> >> - Include NEWS and doc. >> - Fix typos, grammatical mistakes, and changelog entries. >> - Update copyright year from "2013" to "2013-2014" for new files. >> - Use -list-features to return "available-children-only" (#7). >> - Update config/djgpp/fnchange.lst for new tests. >> - Fix a missing cleanup (#2). >> - Call varobj_delete_iter in free_variable (#3). >> >> Regression tested on x86_64-linux. >> > > Ping. https://sourceware.org/ml/gdb-patches/2014-02/msg00489.html > > Can anyone have a look at this patch? Patch 11/12 still depends on > "[PATCH] Accept convenience variable in commands -break-passcount and > -break-commands", but it doesn't matter much for reviewing this patch > series. > > IMO, patches #1 - #6 are refactor to existing code on dynamic varobj, > and can go in regardless of the decision of the rest (MI option > --available-children-only stuff). WDYT? > Ping. -- Yao (齐尧)