Re: [PATCH v2] Fix several "set remote foo-packet on/off" commands.

Pedro Alves
2014-04-29T13:07:07Z

On 04/29/2014 01:53 PM, Joel Brobecker wrote:
> Hi Pedro,
>
>> Bummer, sorry for the trouble.
>
> No problem at all!
>
>> I think the design is sound. See more info in the patch below.
>>
>> I'd be fine with either:
>>
>> - restoring things to how they've "always" been immediately.
>> That is, push the patch below. We can then incrementally add the
>> missing associated commands, along with corresponding manual and
>> possibly testsuite changes/additions, as a non-priority task.
>>
>> - or, adding all the missing commands now, and add an assertion just
>> like in the patch below, but with no exception list, of course.
>> (but TBC, I can't offer to work on that myself now.)
>
> Either approach would be fine with me too. I could even see a two-step
> approach where we apply your first patch as a stop-gap, and then
> implement everything as a setting (I think having the setting for
> every packet could prove useful to interact with difficult remote
> stubs).

Alright, so I just went ahead and pushed the patch in.

Thanks,
--
Pedro Alves