From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22393 invoked by alias); 1 Apr 2014 02:26:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22365 invoked by uid 89); 1 Apr 2014 02:26:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Apr 2014 02:25:59 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WUoOh-0003Ny-5P from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 31 Mar 2014 19:25:55 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 31 Mar 2014 19:25:55 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 31 Mar 2014 19:23:58 -0700 Message-ID: <533A2333.8060700@codesourcery.com> Date: Tue, 01 Apr 2014 02:26:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [PATCH] Check tracefile is generated by binary execution References: <1395733933-9366-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1395733933-9366-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00000.txt.bz2 On 03/25/2014 03:52 PM, Yao Qi wrote: > In gdb.trace/tfile.exp, we execute binary to generate tracefile, > > remote_exec target "$binfile" > > however, this fails on bare metal target. This patch is to > handle binary execution failure by running binary in GDB. > The binary will do some io operation to generate tracefile, so > we need a check 'target_info exists gdb,nofileio'. > > This patch is to check whether tracefile is generated. tfile.exp can > be skipped if generation is failed, while test_tfind_tfile in > mi-traceframe-changed.exp is skipped if generated failed. The rest of > the mi-traceframe-changed.exp can still be executed, because on some > bare metal targets, the remote stub may support tracepoint but doesn't > support fileio. > > This patch is tested on nios2-elf and arm-none-eabi. > > gdb/testsuite: > > 2014-03-25 Yao Qi > > * lib/trace-support.exp (generate_tracefile): New procedure. > * gdb.trace/tfile.exp: Skip the test if generate_tracefile > return 0. > * gdb.trace/mi-traceframe-changed.exp: Invoke test_tfind_tfile > if generate_tracefile returns 1. Ping. https://sourceware.org/ml/gdb-patches/2014-03/msg00591.html -- Yao (齐尧)