From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111384-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20152 invoked by alias); 24 Mar 2014 18:00:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20138 invoked by uid 89); 24 Mar 2014 18:00:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: service87.mimecast.com
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Mar 2014 18:00:53 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 24 Mar 2014 18:00:50 +0000
Received: from [10.1.208.33] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 24 Mar 2014 18:01:02 +0000
Message-ID: <533072CF.3050702@arm.com>
Date: Mon, 24 Mar 2014 18:00:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: Kyle McMartin <kmcmarti@redhat.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
References: <20140324161056.GB23291@redacted.bos.redhat.com> <20140324165733.GN4282@adacore.com>
In-Reply-To: <20140324165733.GN4282@adacore.com>
X-MC-Unique: 114032418005005101
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-03/txt/msg00582.txt.bz2

On 24/03/14 16:57, Joel Brobecker wrote:
> Hello Kyle,
>> +      /* look for a conditional branch to set a breakpoint on the desti=
nation. */
>=20
> This line looks too long?

Also, comments are full sentences, so begin with a capital letter and
end with a full stop and two spaces.

>> +      /* and the matching store-exclusive to close it. */
>> +      if (decode_masked_match(insn, 0x3fc00000, 0x08000000))
>=20
> Same here...

If you really need a continuation comment like this, then end the
previous one with "..." and start the current one with "... and".
Otherwise, this should be re-written as a stand-alone sentence.