Re: [PATCH 1/3] Move the traceframe_available_memory code from memory_xfer_partial_1 down to the targets

Yao Qi
2014-03-21T09:41:35Z

On 03/11/2014 08:42 PM, Yao Qi wrote:
> As a follow-up to
>
> [PATCH 7/8] Adjust read_value_memory to use to_xfer_partial
> https://sourceware.org/ml/gdb-patches/2014-02/msg00384.html
>
> this patch moves traceframe_available_memory down to the target side.
> After this patch, the gdb core code is cleaner, and code on handling
> unavailable memory is moved to remote/tfile/ctf targets.
>
> In details, this patch moves traceframe_available_memory code from
> memory_xfer_partial_1 to remote target only, so remote target still
> uses traceframe_info mechanism to check unavailable memory, and use
> remote_ops to read them from read-only sections. We don't use
> traceframe_info mechanism for tfile and ctf target, because it is
> fast to iterate all traceframes from trace file, so the summary
> information got from traceframe_info is not necessary.
>
> This patch also moves two functions to remote.c from target.c,
> because they are only used in remote.c. I'll clean them up in another
> patch.
>
> This series is tested on x86_64-linux.
>
> gdb:
>
> 2014-03-11 Yao Qi <yao@codesourcery.com>
>
> * ctf.c (ctf_xfer_partial): Check the return value of
> exec_read_partial_read_only, if it is not TARGET_XFER_OK,
> return TARGET_XFER_UNAVAILABLE.
> * tracefile-tfile.c (tfile_xfer_partial): Likewise.
> * target.c (target_read_live_memory): Move it to remote.c.
> (memory_xfer_live_readonly_partial): Likewise.
> (memory_xfer_partial_1): Move some code to remote_read_bytes.
> * remote.c (target_read_live_memory): Moved from target.c.
> (memory_xfer_live_readonly_partial): Likewise.
> (remote_read_bytes): Moved from memory_xfer_partial_1.

Ping. https://sourceware.org/ml/gdb-patches/2014-03/msg00262.html

--
Yao (é½å°§)