From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6879 invoked by alias); 21 Mar 2014 12:01:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6864 invoked by uid 89); 21 Mar 2014 12:01:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Mar 2014 12:01:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2LC0qlW004307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Mar 2014 08:00:53 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2LC0oJZ017306; Fri, 21 Mar 2014 08:00:51 -0400 Message-ID: <532C29F2.1090302@redhat.com> Date: Fri, 21 Mar 2014 12:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Remove target_read_live_memory References: <1394541731-27486-1-git-send-email-yao@codesourcery.com> <1394541731-27486-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1394541731-27486-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00520.txt.bz2 On 03/11/2014 12:42 PM, Yao Qi wrote: > As we move code on reading unavailable memory to target side, GDB core > side doesn't need the "switching momentarily out of tfind mode" dance. > The target remote knows how to read live memory (through remote_ops). > > Remove set_traceframe_number and > make_cleanup_restore_traceframe_number, since they are no longer used. Awesome. Thanks for doing this. > - > -/* Using the set of read-only target sections of OPS, read live > - read-only memory. Note that the actual reads start from the > - top-most target again. > +/* Using the set of read-only target sections of remote, read live > + read-only memory. > > For interface/parameters/return description see target.h, > to_xfer_partial. */ > > static enum target_xfer_status > -memory_xfer_live_readonly_partial (struct target_ops *ops, > - enum target_object object, > - gdb_byte *readbuf, ULONGEST memaddr, > +remote_xfer_live_readonly_partial (gdb_byte *readbuf, ULONGEST memaddr, > ULONGEST len, ULONGEST *xfered_len) > { > struct target_section *secp; > struct target_section_table *table; > + struct target_ops *ops = &remote_ops; This reference to remote_ops must be removed, per my comment to patch 1. IOW, OPS needs to stay. (The intro comment should then still say "of OPS".) Otherwise looks good. Thanks, -- Pedro Alves