From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10577 invoked by alias); 21 Mar 2014 09:41:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10565 invoked by uid 89); 21 Mar 2014 09:41:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Mar 2014 09:41:33 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WQvxB-0004Iq-N3 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Fri, 21 Mar 2014 02:41:29 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 21 Mar 2014 02:41:29 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Fri, 21 Mar 2014 02:41:28 -0700 Message-ID: <532C08BB.3080400@codesourcery.com> Date: Fri, 21 Mar 2014 09:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [PATCH 1/3] Move the traceframe_available_memory code from memory_xfer_partial_1 down to the targets References: <1394541731-27486-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1394541731-27486-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00516.txt.bz2 On 03/11/2014 08:42 PM, Yao Qi wrote: > As a follow-up to > > [PATCH 7/8] Adjust read_value_memory to use to_xfer_partial > https://sourceware.org/ml/gdb-patches/2014-02/msg00384.html > > this patch moves traceframe_available_memory down to the target side. > After this patch, the gdb core code is cleaner, and code on handling > unavailable memory is moved to remote/tfile/ctf targets. > > In details, this patch moves traceframe_available_memory code from > memory_xfer_partial_1 to remote target only, so remote target still > uses traceframe_info mechanism to check unavailable memory, and use > remote_ops to read them from read-only sections. We don't use > traceframe_info mechanism for tfile and ctf target, because it is > fast to iterate all traceframes from trace file, so the summary > information got from traceframe_info is not necessary. > > This patch also moves two functions to remote.c from target.c, > because they are only used in remote.c. I'll clean them up in another > patch. > > This series is tested on x86_64-linux. > > gdb: > > 2014-03-11 Yao Qi > > * ctf.c (ctf_xfer_partial): Check the return value of > exec_read_partial_read_only, if it is not TARGET_XFER_OK, > return TARGET_XFER_UNAVAILABLE. > * tracefile-tfile.c (tfile_xfer_partial): Likewise. > * target.c (target_read_live_memory): Move it to remote.c. > (memory_xfer_live_readonly_partial): Likewise. > (memory_xfer_partial_1): Move some code to remote_read_bytes. > * remote.c (target_read_live_memory): Moved from target.c. > (memory_xfer_live_readonly_partial): Likewise. > (remote_read_bytes): Moved from memory_xfer_partial_1. Ping. https://sourceware.org/ml/gdb-patches/2014-03/msg00262.html -- Yao (齐尧)