Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>,
	gdb-patches@sourceware.org,
	       Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v4 8/8] Tests for validate symbol file using build-id
Date: Thu, 20 Mar 2014 13:12:00 -0000	[thread overview]
Message-ID: <532AE939.8000805@redhat.com> (raw)
In-Reply-To: <20140319223307.GB5398@host2.jankratochvil.net>

On 03/19/2014 10:33 PM, Jan Kratochvil wrote:
> On Mon, 10 Mar 2014 04:36:15 +0100, Yao Qi wrote:
>> On 03/03/2014 03:53 AM, Jan Kratochvil wrote:
>>> gdb/testsuite/
>>> 2014-02-26  Aleksandar Ristovski  <aristovski@qnx.com
>>>
>>> 	Tests for validate symbol file using build-id.
>>> 	* gdb.base/solib-mismatch-lib.c: New file.
>>> 	* gdb.base/solib-mismatch-libmod.c: New file.
>>> 	* gdb.base/solib-mismatch.c: New file.
>>> 	* gdb.base/solib-mismatch.exp: New file.
>>
>> Since the test is about GDBserver, so IWBN to move them
>> testsuite/gdb.server/ directory.
> 
> Done.

Sorry I missed this part of the discussion.

I'd rather not put this in gdb.server/.  It just happens that
GDBserver implements the support for this, but nothing stops other
targets from implementing the same.  gdb.server/ is about tests
that truly have GDBserver specific logic, doing things like
gdbserver_start, gdbserver_spawn, gdbserver_start_extended,
or some such.

-- 
Pedro Alves


  parent reply	other threads:[~2014-03-20 13:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-02 19:53 [PATCH v4 0/8] Validate binary before use Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 3/8] Create empty common/linux-maps.[ch] and common/common-target.[ch] Jan Kratochvil
2014-03-10  3:46   ` Yao Qi
2014-03-19 22:33     ` Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 4/8] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 1/8] Move utility functions to common/ Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 5/8] Move linux_find_memory_regions_full & co Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 2/8] Merge multiple hex conversions Jan Kratochvil
2014-03-02 19:53 ` [PATCH v4 6/8] gdbserver build-id attribute generator Jan Kratochvil
2014-03-02 20:47   ` Eli Zaretskii
2014-03-02 19:54 ` [PATCH v4 7/8] Validate symbol file using build-id Jan Kratochvil
2014-03-02 19:54 ` [PATCH v4 8/8] Tests for validate " Jan Kratochvil
2014-03-10  3:38   ` Yao Qi
2014-03-19 22:33     ` Jan Kratochvil
2014-03-20 12:16       ` Yao Qi
2014-03-20 13:12       ` Pedro Alves [this message]
2014-03-21 16:58         ` Jan Kratochvil
2014-03-02 20:47 ` [PATCH v4 0/8] Validate binary before use Eli Zaretskii
2014-03-08 19:57   ` Jan Kratochvil
2014-03-09 16:53     ` Eli Zaretskii
2014-03-09 18:58       ` Jan Kratochvil
2014-03-09 19:19         ` Eli Zaretskii
2014-03-19 22:33           ` Jan Kratochvil
2014-03-21 16:58       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532AE939.8000805@redhat.com \
    --to=palves@redhat.com \
    --cc=ARistovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox