From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6566 invoked by alias); 18 Mar 2014 17:33:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6556 invoked by uid 89); 18 Mar 2014 17:33:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Mar 2014 17:33:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2IHXJ69005949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Mar 2014 13:33:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2IHXH4o004012; Tue, 18 Mar 2014 13:33:18 -0400 Message-ID: <5328835C.4010908@redhat.com> Date: Tue, 18 Mar 2014 17:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix "PC register is not available" issue References: <83txawa9wk.fsf@gnu.org> <20140318161608.GD4282@adacore.com> <83pplja2h9.fsf@gnu.org> <20140318165413.GE4282@adacore.com> <83k3bra0rx.fsf@gnu.org> In-Reply-To: <83k3bra0rx.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00423.txt.bz2 On 03/18/2014 05:12 PM, Eli Zaretskii wrote: >> Date: Tue, 18 Mar 2014 09:54:13 -0700 >> From: Joel Brobecker >> Cc: gdb-patches@sourceware.org >> >>>> Another thought I had on your patch is that we might want to limit >>>> the warning to situation where the return code is not a permission >>>> denied. >>> >>> I'm not sure we should bother. After all, if the problem is real, we >>> will get an error further down the line, when we use the handle to >>> that thread to do something with it. >>> >>> IOW, I see no need to thrash the entire session because of something >>> that isn't fatal. >> >> I didn't mean to change the behavior - only hide the warning. > > Ah, OK. I think I'll do that in the next version of the patch. > >> I think the only part we need to look at before putting your patch >> in is analyzing its side-effects. > > I'll look into that and post the results. I see that the GetThreadContext call (do_windows_fetch_inferior_registers) doesn't check for errors (I think it should (*)). It'd be interesting to know whether gdb can actually read the registers off of this thread, and if so, what's the thread's backtrace like. (*) - note the other place that calls GetThreadContext does it under a CHECK: CHECK (GetThreadContext (th->h, &th->context)); -- Pedro Alves