From: Hui Zhu <hui_zhu@mentor.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [PATCH 1/1] Fix memleak of the pid_to_exec_file target_ops method for some platforms
Date: Mon, 17 Mar 2014 16:02:00 -0000 [thread overview]
Message-ID: <53271C80.1040103@mentor.com> (raw)
In-Reply-To: <53271C09.5000709@mentor.com>
I said most of the pid_to_exec_file target_ops method for some platforms will
allocate memory for exec_file and add them to cleanup.
But some of them didn't do that.
So I make a patch to fix this memleak.
Thanks,
Hui
2014-03-17 Hui Zhu <hui@codesourcery.com>
* fbsd-nat.c (fbsd_pid_to_exec_file): Add make_cleanup.
* nbsd-nat.c (nbsd_pid_to_exec_file): Ditto.
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -43,6 +43,8 @@ fbsd_pid_to_exec_file (struct target_ops
char *buf = xcalloc (len, sizeof (char));
char *path;
+ make_cleanup (xfree, buf);
+
#ifdef KERN_PROC_PATHNAME
int mib[4];
--- a/gdb/nbsd-nat.c
+++ b/gdb/nbsd-nat.c
@@ -31,6 +31,8 @@ nbsd_pid_to_exec_file (struct target_ops
char *buf = xcalloc (len, sizeof (char));
char *path;
+ make_cleanup (xfree, buf);
+
path = xstrprintf ("/proc/%d/exe", pid);
if (readlink (path, buf, PATH_MAX - 1) == -1)
{
next prev parent reply other threads:[~2014-03-17 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 16:00 [PATCH 0/1] Fix internal warning when "gdb -p xxx" Hui Zhu
2014-03-17 16:02 ` Hui Zhu [this message]
2014-03-18 7:39 ` [PATCH 1/1] Fix memleak of the pid_to_exec_file target_ops method for some platforms Hui Zhu
2014-03-17 16:12 ` [PATCH 0/1] Fix internal warning when "gdb -p xxx" Pedro Alves
2014-03-17 16:57 ` Pedro Alves
2014-03-18 7:38 ` Hui Zhu
2014-03-18 10:14 ` Pedro Alves
2014-03-19 3:58 ` Hui Zhu
2014-03-19 10:16 ` Pedro Alves
2014-03-20 2:58 ` Hui Zhu
2014-03-20 3:27 ` Hui Zhu
2014-03-20 12:56 ` Pedro Alves
2014-03-21 3:14 ` Hui Zhu
2014-03-19 4:03 ` [PATCH 1/1] Fix internal warning when "gdb -p xxx" (test) Hui Zhu
2014-03-19 10:28 ` Pedro Alves
2014-03-20 3:16 ` Hui Zhu
2014-03-20 12:23 ` Pedro Alves
2014-03-21 3:27 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53271C80.1040103@mentor.com \
--to=hui_zhu@mentor.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox