From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11546 invoked by alias); 12 Mar 2014 17:18:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11531 invoked by uid 89); 12 Mar 2014 17:18:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 17:18:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2CHIOcC006147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Mar 2014 13:18:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2CHILLc014622; Wed, 12 Mar 2014 13:18:22 -0400 Message-ID: <532096DD.2020201@redhat.com> Date: Wed, 12 Mar 2014 17:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC v5] fix regressions with target-async References: <1394642546-10555-1-git-send-email-tromey@redhat.com> In-Reply-To: <1394642546-10555-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00294.txt.bz2 This is OK, please push it in. On 03/12/2014 04:42 PM, Tom Tromey wrote: > While working on this I noticed that there don't seem to be any test > cases that involve both target-async and record, so this patch changes > break-precsave.exp to add some. It also changes corefile.exp to add > some target-async tests; these pass with current trunk and with this > patch applied, but fail with the v1 patch. I was looking at the async-by-default series, and pondering this --- after the "target async by default" series, "set target-async" is really an MI setting, so it'll be irrelevant and really useless for these tests. We'll have an alternative "maint set target-async off/on", but I don't think we should use it to force specific tests to run in sync mode -- rather my idea for it was to it from a board file for the occasional comfortable testing and emulation of !Linux targets. So in the end, after the target-async series, I think we should go through non-MI tests and remove all that do "set target-async on". -- Pedro Alves