From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5289 invoked by alias); 7 Mar 2014 15:38:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5278 invoked by uid 89); 7 Mar 2014 15:38:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Mar 2014 15:38:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s27FcEcx012465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Mar 2014 10:38:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s27FcCFC018096; Fri, 7 Mar 2014 10:38:13 -0500 Message-ID: <5319E7E4.7000807@redhat.com> Date: Fri, 07 Mar 2014 15:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Make the go32-nat.c target inherit inf-child.c. References: <1394205292-19784-1-git-send-email-palves@redhat.com> <1394205292-19784-2-git-send-email-palves@redhat.com> <831tyeqb2i.fsf@gnu.org> In-Reply-To: <831tyeqb2i.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00194.txt.bz2 On 03/07/2014 03:32 PM, Eli Zaretskii wrote: >> gdb/ >> 2014-03-07 Pedro Alves >> >> * go32-nat.c: Include inf-child.h. >> (go32_ops): Delete global. >> (go32_close, go32_detach, go32_prepare_to_store, go32_can_run): >> Delete methods. >> (go32_create_inferior): Push the passed in target pointer instead >> of referencing go32_ops. >> (init_go32_ops): Delete function. Moved parts to _initialize_go32_nat. >> (go32_target): New function, based on init_go32_ops, but inherit >> inf_child_target. >> (_initialize_go32_nat): Use go32_target. Move parts of >> init_go32_ops here. > > This is OK, thanks. Thanks, pushed. -- Pedro Alves