From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19637 invoked by alias); 5 Mar 2014 20:33:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19623 invoked by uid 89); 5 Mar 2014 20:33:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 20:33:49 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25KXkaq019940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Mar 2014 15:33:46 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s25KXiXP003061; Wed, 5 Mar 2014 15:33:45 -0500 Message-ID: <53178A28.8060206@redhat.com> Date: Wed, 05 Mar 2014 20:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR16508 References: <1392447370-22318-1-git-send-email-yao@codesourcery.com> <87lhwo76qv.fsf@fleche.redhat.com> In-Reply-To: <87lhwo76qv.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00139.txt.bz2 On 03/05/2014 08:03 PM, Tom Tromey wrote: > Yao> +if [prepare_for_testing $expfile $executable $srcfile \ > Yao> + [list debug]] { > Yao> + untested "failed to prepare for trace tests" > > prepare calls untested for you, so no need to do it again. Note that the first argument to prepare_for_testing is what is passed to untested (and really only used for that), so a better alternative even is to do: if [prepare_for_testing "failed to prepare for trace tests" \ $executable $srcfile [list debug]] { Although we do that all over the place, passing $expfile to untested is useless, as that information will be in the gdb.sum before UNTESTED anyway. I'd support us starting to use this pattern more. -- Pedro Alves