From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5546 invoked by alias); 5 Mar 2014 15:59:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5535 invoked by uid 89); 5 Mar 2014 15:58:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 15:58:59 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25Fwr9l022694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Mar 2014 10:58:54 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s25Fwpdi030258; Wed, 5 Mar 2014 10:58:52 -0500 Message-ID: <531749BA.8050806@redhat.com> Date: Wed, 05 Mar 2014 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Error on bad count number References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-3-git-send-email-yao@codesourcery.com> <20140305142939.GB16858@adacore.com> In-Reply-To: <20140305142939.GB16858@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00126.txt.bz2 On 03/05/2014 02:29 PM, Joel Brobecker wrote: >> GDB is quiet for these invalid input like this >> >> (gdb) enable count 1.1 1 >> (gdb) >> >> This patch is to check the input number is valid, and emit error if >> input number isn't valid. With this patch, it becomes: >> >> (gdb) enable count 1.1 1 >> Bad count number '1.1 1' >> >> gdb: >> >> 2014-03-05 Yao Qi >> >> * breakpoint.c (enable_count_command): Emit error if 'count' >> is zero. >> >> gdb/testsuite: >> >> 2014-03-05 Yao Qi >> >> * gdb.base/ena-dis-br.exp: Test bad count number. > > I had a slight hesitation here, as we are now going to actively > reject "enable count 0 1" where it used to be accepted. But since > it makes little sense, and does not work, I think that's OK. > Example of it not working: I had the same thought. I wondered whether 0 was meant to remove the enable count, but the docs don't say anything about it. Is there another way to disable the count, and bring back the disposition to enabled? If not, I wonder whether using 0 for that would be a good idea? -- Pedro Alves