From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17838 invoked by alias); 5 Mar 2014 15:35:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17829 invoked by uid 89); 5 Mar 2014 15:35:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 15:35:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25FZtBw021688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 10:35:55 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s25FZrB2011684 for ; Wed, 5 Mar 2014 10:35:54 -0500 Message-ID: <53174459.1010709@redhat.com> Date: Wed, 05 Mar 2014 15:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] PR breakpoints/7143 - Watchpoint does not trigger when first set References: <1393360363-5603-1-git-send-email-palves@redhat.com> <1393360363-5603-3-git-send-email-palves@redhat.com> In-Reply-To: <1393360363-5603-3-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00124.txt.bz2 On 02/25/2014 08:32 PM, Pedro Alves wrote: > + if (ecs->event_thread->stepping_over_breakpoint > + && !use_displaced_stepping (get_regcache_arch (regcache))) > { > - struct regcache *thread_regcache = get_thread_regcache (ecs->ptid); > + /* Can't step over more than one breakpoint simultaneously > + without displaced stepping. */ > + gdb_assert (step_over_aspace == NULL); While working on further changes on top of this series, I noticed something wrong. Then I decided to reorder the patches a little, and add another watchpoint-related test, which then managed to trigger this assertion, because we - stepped a thread - got to the thread_hop code without clearing step_over_aspace. v2 will clear step_over_aspace earlier to avoid that. It's still a good idea to do that even though the series ends up eliminating the thread hop code. -- Pedro Alves